Fix some build warnings

Mostly these were about removing unused fields. PiperOrigin-RevId: 362547797
google · Mar 12, 2021 · 866efae · 866efae
1 parent c57876a
commit 866efae
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 5 deletions.
diff --git a/...ePlayPlugins/com.google.android.appbundle/Editor/Scripts/Internal/BuildTools/ApkSigner.cs b/...ePlayPlugins/com.google.android.appbundle/Editor/Scripts/Internal/BuildTools/ApkSigner.cs
@@ -41,11 +41,13 @@ public class ApkSigner : IBuildTool
         private readonly AndroidBuildTools _androidBuildTools;
         private readonly JavaUtils _javaUtils;
 
+#if !UNITY_2018_1_OR_NEWER
         private string _apkSignerJarPath;
         private string _keystoreName;
         private string _keystorePass;
         private string _keyaliasName;
         private string _keyaliasPass;
+#endif
 
         /// <summary>
         /// Constructor.

diff --git a/...gins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetBundleRequestImpl.cs b/...gins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetBundleRequestImpl.cs
@@ -25,7 +25,6 @@ internal class PlayAssetBundleRequestImpl : PlayAssetBundleRequest
         private readonly AssetDeliveryUpdateHandler _updateHandler;
         private AssetDeliveryStatus _loadingStatus;
         private AssetDeliveryErrorCode _loadingError;
-        private float _downloadProgress;
 
         public PlayAssetBundleRequestImpl(PlayAssetPackRequestImpl packRequest,
             AssetDeliveryUpdateHandler updateHandler)

diff --git a/...ugins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetDeliveryInternal.cs b/...ugins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetDeliveryInternal.cs
@@ -34,7 +34,6 @@ internal class PlayAssetDeliveryInternal
         private const string AssetPackFolderName = "assetpack";
 
         private readonly AssetPackManager _assetPackManager;
-        private readonly AssetPackStateUpdateListener _stateUpdateListener;
         private readonly AssetDeliveryUpdateHandler _updateHandler;
 
         private readonly PlayRequestRepository _requestRepository = new PlayRequestRepository();

diff --git a/...ns/com.google.play.assetdelivery/Samples/AssetDeliveryDemo/Scripts/AssetPackDownloader.cs b/...ns/com.google.play.assetdelivery/Samples/AssetDeliveryDemo/Scripts/AssetPackDownloader.cs
@@ -45,7 +45,6 @@ public class AssetPackDownloader : MonoBehaviour
 
         private AssetBundle _assetBundle;
         private PlayAssetPackRequest _request;
-        private List<Button> _buttons;
         private bool _requestInProgress;
 
         public bool IsInitialized { get; private set; }

diff --git a/...PlayPlugins/com.google.play.common/Runtime/Scripts/LoadingScreen/ScrollingFillAnimator.cs b/...PlayPlugins/com.google.play.common/Runtime/Scripts/LoadingScreen/ScrollingFillAnimator.cs
@@ -32,7 +32,6 @@ public class ScrollingFillAnimator : MonoBehaviour
         public float ScrollSpeed = 2.5f;
 
         private RawImage _image;
-        private Vector2 _textureOffset;
         private RectTransform _rectTransform;
 
         private void Update()

diff --git a/GooglePlayPlugins/com.google.play.review/Runtime/Scripts/ReviewManager.cs b/GooglePlayPlugins/com.google.play.review/Runtime/Scripts/ReviewManager.cs
@@ -28,7 +28,10 @@ public class ReviewManager
         /// href="https://developer.android.com/reference/com/google/android/play/core/review/model/ReviewErrorCode"></a>
         /// </summary>
         private const int JavaReviewErrorCodePlayNotFound = -1;
+
+#if !UNITY_EDITOR
         private readonly ReviewPlayCoreTaskManager _reviewPlayCoreTaskManager;
+#endif
 
         public ReviewManager()
         {
@@ -112,4 +115,4 @@ private PlayAsyncOperation<VoidResult, ReviewErrorCode> LaunchReviewFlowInternal
         }
 #endif
     }
-}
+}