Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Play Instant plugin incorrectly enforces OpenGLES2 requirement #70

Closed
nilsk123 opened this issue Nov 22, 2020 · 3 comments
Closed

Google Play Instant plugin incorrectly enforces OpenGLES2 requirement #70

nilsk123 opened this issue Nov 22, 2020 · 3 comments
Assignees
@thanwah

Comments

@nilsk123
Copy link

Hello,

The latest Google Play Instant plugin will only build an AAB if OpenGLES2 is the only graphics api enabled. This requirement is outdated and should be removed, as it prevents apps using ARFoundation from being packed as instant apps
@thanwah thanwah self-assigned this Nov 30, 2020
@thanwah
Copy link
Contributor

thanwah commented Nov 30, 2020

Thanks @nilsk123 for filing this. You're right that this requirement is somewhat outdated since it doesn't apply to instant apps configured to support a minimum version of Android Oreo (API 26) or newer. I'll try to put up a fix this week, though I may not have time to do a full release.

thanwah pushed a commit that referenced this issue Dec 4, 2020
@thanwah
Don't require GLES2 for instant apps with min SDK 26+
2f17285 
Pre-Oreo devices only support instant apps using OpenGLES2, so we keep this as a requirement when an app's minimum SDK is 25 or lower. However, apps that only support Oreo+ should be able to use any Graphics API.

Fixes issue #70

PiperOrigin-RevId: 345583664
@thanwah
Copy link
Contributor

thanwah commented Dec 4, 2020

A fix is now committed. As mentioned though, I'm not sure when I'll have time to do a full release containing this change.

@thanwah thanwah closed this as completed Dec 4, 2020
@nilsk123
Copy link
Author

nilsk123 commented Dec 7, 2020

Thanks for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanwah thanwah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nilsk123 @thanwah