test: update node versions in tests #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanmar511
approved these changes
Apr 29, 2022
|
Another option might be to drop tests for Node 18 until we're positioned to support Node 18. (Your call on what the right path forward is) |
nolanmar511
approved these changes
Apr 29, 2022
|
Tests are passing except for node 18 which is expected. Going to force merge this one, and will potentially work on another PR to workaround the node 18 issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #170, but doesn't completely fix it yet because node 18 tests are still failing. Here's the upstream tracking issue for
source-map.Updated workflow YAML file to test versions 12, 14, 16, 17, and 18. I needed to disable the fail-fast option; otherwise, any other test would be cancelled as soon as v18 fails.
Prebuilt binary tests depend on node-pre-gyp which only supports up to version 16 now, so version 17 and 18 aren't included in prebuilt binary tests.
Kokoro tests are also expected to fail for version 18, so for now will just make sure from the logs that the only failing test is for version 18 and the remaining versions pass.