Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support for Node 12; finish adding support for Node 18 #215

Closed
wants to merge 2 commits into from

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented May 4, 2022

Breaking change

Blocked by mapbox/node-pre-gyp#647

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #215 (78d387b) into main (f6ac01d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   42.21%   42.21%           
=======================================
  Files          14       14           
  Lines        2061     2061           
  Branches       42       42           
=======================================
  Hits          870      870           
  Misses       1173     1173           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ac01d...78d387b. Read the comment docs.

@nolanmar511 nolanmar511 force-pushed the supported-node-versions branch from 78d387b to 3f841d3 Compare May 4, 2022 20:26
@rauno56
Copy link

rauno56 commented Jun 14, 2022

Depending on your build setup, this should now be straight-forward to enable. nan has to definitely be upgraded.
We're using prebuildify instead of node-pre-gyp though. See signalfx/splunk-otel-js@25a24ac

@nolanmar511
Copy link
Contributor Author

nolanmar511 commented Jun 14, 2022

Based on the success of the ci/kokoro: system test with Node 18, it's likely that if one installs from code on Github and looks at node-gyp to ensure one has dependencies necessary to build binaries (documentation notes these) one will be able to use the pprof-nodejs repo with Node 18. pprof-nodejs (at head) is already tested against the v8-canary regularly.

I don't think that I would recommend this for production code; but for experimentation with Node 18, this approach may work.

As noted in the CL description, this CL's submission is currently blocked by a node-pre-gyp issue (which prevents pre-built binaries from being created given out current release process).

@nolanmar511
Copy link
Contributor Author

Closing this PR based on mapbox/node-pre-gyp#657.

Given the current state of node-pre-gyp and my current level of involvement with this repo, I do not think I'm the right owner for adding Node 18 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants