feat: add pre-built binaries for Node 12 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PTAL E2E tests are now passing (I'd forgotten to update the script so binaries for 12 were actually built). |
kalyanac
reviewed
Jun 12, 2019
system-test/Dockerfile.node12-alpine
Outdated
|
|
||
| RUN apk add --no-cache bash $ADDITIONAL_PACKAGES | ||
| WORKDIR /root/ | ||
| COPY --from=0 /go/bin/pprof /bin |
There was a problem hiding this comment.
Done (for this and other alpine docker files)
nolanmar511
force-pushed
the
add-12
branch
2 times, most recently
from
4eec041 to
a931c6e
Compare
|
PTAL |
kalyanac
approved these changes
Jun 17, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #66
After this, I'll need to enable continuous and presubmit unit tests for Node 12 (though I add the kokoro configs here).