Skip to content

Commit

Permalink
Report missing file name as "", not "." (#899)
Browse files Browse the repository at this point in the history
  • Loading branch information
ghemawat authored Sep 27, 2024
1 parent d43a673 commit cba816a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions internal/report/shortnames.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ var (
// fileNameSuffixes returns a non-empty sequence of shortened file names
// (in decreasing preference) that can be used to represent name.
func fileNameSuffixes(name string) []string {
if name == "" {
// Avoid returning "." when symbol info is missing
return []string{""}
}
return allSuffixes(filepath.ToSlash(filepath.Clean(name)), fileSepRE)
}

Expand Down
2 changes: 1 addition & 1 deletion internal/report/shortnames_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestFileNameSuffixes(t *testing.T) {
}

for _, c := range []testCase{
test("empty", "", "."),
test("empty", "", ""),
test("simple", "foo", "foo"),
test("manypaths", "a/b/c", "a/b/c", "b/c", "c"),
test("leading", "/a/b", "/a/b", "a/b", "b"),
Expand Down

0 comments on commit cba816a

Please sign in to comment.