Skip to content

Commit

Permalink
getting rid of percentile_0
Browse files Browse the repository at this point in the history
  • Loading branch information
Maaarcocr committed Dec 1, 2017
1 parent 3c1cc88 commit f20b0fa
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
38 changes: 19 additions & 19 deletions internal/driver/testdata/pprof.cpu.flat.addresses.weblist
Original file line number Diff line number Diff line change
Expand Up @@ -84,36 +84,36 @@ Duration: 10s, Total samples = 1.12s (11.20%)<br>Total: 1.12s</div><h2>line1000<
. . 1003: instruction four <span class=unimportant>file1000.src:1</span>
</span>
<span class=line> 2</span> <span class="deadsrc percentile_0"> . . line2 </span><span class=asm> . . 1002: instruction three <span class=unimportant>file1000.src:2</span>
<span class=line> 2</span> <span class="deadsrc "> . . line2 </span><span class=asm> . . 1002: instruction three <span class=unimportant>file1000.src:2</span>
</span>
<span class=line> 3</span> <span class="nop percentile_0"> . . line3 </span>
<span class=line> 4</span> <span class="nop percentile_0"> . . line4 </span>
<span class=line> 5</span> <span class="nop percentile_0"> . . line5 </span>
<span class=line> 6</span> <span class="nop percentile_0"> . . line6 </span>
<span class=line> 7</span> <span class="nop percentile_0"> . . line7 </span>
<span class=line> 3</span> <span class="nop "> . . line3 </span>
<span class=line> 4</span> <span class="nop "> . . line4 </span>
<span class=line> 5</span> <span class="nop "> . . line5 </span>
<span class=line> 6</span> <span class="nop "> . . line6 </span>
<span class=line> 7</span> <span class="nop "> . . line7 </span>
</pre>
<h2>line3000</h2><p class="filename">testdata/file3000.src</p>
<pre onClick="pprof_toggle_asm(event)">
Total: 10ms 1.12s (flat, cum) 100%
<span class=line> 1</span> <span class="nop percentile_0"> . . line1 </span>
<span class=line> 2</span> <span class="nop percentile_0"> . . line2 </span>
<span class=line> 3</span> <span class="nop percentile_0"> . . line3 </span>
<span class=line> 4</span> <span class="nop percentile_0"> . . line4 </span>
<span class=line> 5</span> <span class="nop percentile_0"> . . line5 </span>
<span class=line> 1</span> <span class="nop "> . . line1 </span>
<span class=line> 2</span> <span class="nop "> . . line2 </span>
<span class=line> 3</span> <span class="nop "> . . line3 </span>
<span class=line> 4</span> <span class="nop "> . . line4 </span>
<span class=line> 5</span> <span class="nop "> . . line5 </span>
<span class=line> 6</span> <span class="deadsrc percentile_80"> 10ms 1.01s line6 </span><span class=asm> 10ms 1.01s 3000: instruction one <span class=unimportant>file3000.src:6</span>
</span>
<span class=line> 7</span> <span class="nop percentile_0"> . . line7 </span>
<span class=line> 8</span> <span class="nop percentile_0"> . . line8 </span>
<span class=line> 9</span> <span class="deadsrc percentile_0"> . 110ms line9 </span><span class=asm> . 100ms 3001: instruction two <span class=unimportant>file3000.src:9</span>
<span class=line> 7</span> <span class="nop "> . . line7 </span>
<span class=line> 8</span> <span class="nop "> . . line8 </span>
<span class=line> 9</span> <span class="deadsrc "> . 110ms line9 </span><span class=asm> . 100ms 3001: instruction two <span class=unimportant>file3000.src:9</span>
. 10ms 3002: instruction three <span class=unimportant>file3000.src:9</span>
. . 3003: instruction four <span class=unimportant></span>
. . 3004: instruction five <span class=unimportant></span>
</span>
<span class=line> 10</span> <span class="nop percentile_0"> . . line0 </span>
<span class=line> 11</span> <span class="nop percentile_0"> . . line1 </span>
<span class=line> 12</span> <span class="nop percentile_0"> . . line2 </span>
<span class=line> 13</span> <span class="nop percentile_0"> . . line3 </span>
<span class=line> 14</span> <span class="nop percentile_0"> . . line4 </span>
<span class=line> 10</span> <span class="nop "> . . line0 </span>
<span class=line> 11</span> <span class="nop "> . . line1 </span>
<span class=line> 12</span> <span class="nop "> . . line2 </span>
<span class=line> 13</span> <span class="nop "> . . line3 </span>
<span class=line> 14</span> <span class="nop "> . . line4 </span>
</pre>

</body>
Expand Down
2 changes: 1 addition & 1 deletion internal/report/source.go
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ func calculatePercentile(partial, sum int64) string {
case percentile > 10:
return "percentile_10"
}
return "percentile_0"
return ""
}

// printFunctionSourceLine prints a source line and the corresponding assembly.
Expand Down

0 comments on commit f20b0fa

Please sign in to comment.