Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exe_windows_64.exe getting flagged by Antivirus #607

Closed
PandiPanda69 opened this issue Feb 22, 2021 · 5 comments · Fixed by #608
Closed

exe_windows_64.exe getting flagged by Antivirus #607

PandiPanda69 opened this issue Feb 22, 2021 · 5 comments · Fixed by #608

Comments

@PandiPanda69
Copy link

Hello guys,

On the current master branch (commit 1612e9b), the binary internal/binutils/testdata/exe_windows_64.exe is getting flagged by different Antivirus vendors as you can see on VT :
https://www.virustotal.com/gui/file/291aec4e3351ae7dc2b8426fd9e1e72f0f7b63b85a8d5588bd6d3f478a3c5f4c/detection

Obviously this is a false positive but it does trigger the Antivirus each time a git pull is performed.
@aalexand
Copy link
Collaborator

@egonelbre Do you mind taking a look? I don't want to roll back #593 but I also don't like having in the repo something that triggers AV checks.

@egonelbre
Copy link
Contributor

Yeah, totally understand. It seems that building with clang the binary doesn't trigger the check.

One option might also be to rename to exe_windows_64_exe, although that might still trigger it.

@aalexand
Copy link
Collaborator

Any downsides of building with clang?

I suspect renaming wouldn't help as it probably inspects the content.

@egonelbre
Copy link
Contributor

After building with clang I'm unable to get the symbols (i.e. nm and llvm-nm both report "no symbols"). I'm not sure what I'm missing, most likely some flag.

egonelbre added a commit to egonelbre/pprof that referenced this issue Feb 24, 2021
@egonelbre
pprof/internal/binutils: update windows test binary
f65d824 
Recompiled test binary using MSYS2 gcc 10.2.0 and verified
that the binary does not trigger anti-virus using virustotal.

Fixes google#607
@egonelbre egonelbre mentioned this issue Feb 24, 2021
Merged
@egonelbre
Copy link
Contributor

egonelbre commented Feb 24, 2021 •
edited
Loading

After tons of failed attempts, I got it finally to not trigger virustotal using MSYS2 gcc 10.2.0.

https://www.virustotal.com/gui/file/65d7d12d1304366522de3d552d3e450f26ef0f8919f46465cce1bbfaa412561d/detection

egonelbre added a commit to egonelbre/pprof that referenced this issue Feb 24, 2021
@egonelbre
pprof/internal/binutils: update windows test binary
3cc6104 
Recompiled test binary using MSYS2 gcc 10.2.0 and verified
that the binary does not trigger anti-virus using virustotal.

Fixes google#607
egonelbre added a commit to egonelbre/pprof that referenced this issue Feb 25, 2021
@egonelbre
pprof/internal/binutils: update windows test binary
f721847 
Recompiled test binary using MSYS2 gcc 10.2.0 and verified
that the binary does not trigger anti-virus using virustotal.

Fixes google#607
egonelbre added a commit to egonelbre/pprof that referenced this issue Feb 25, 2021
@egonelbre
pprof/internal/binutils: update windows test binary
67bf4e8 
Recompiled test binary using MSYS2 gcc 10.2.0 and verified
that the binary does not trigger anti-virus using virustotal.

Fixes google#607
aalexand pushed a commit that referenced this issue Feb 26, 2021
@egonelbre
pprof/internal/binutils: update windows test binary (#608)
c5db671 
Recompiled test binary using MSYS2 gcc 10.2.0 and verified
that the binary does not trigger anti-virus using virustotal.

Fixes #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pprof/internal/binutils: update windows test binary egonelbre/pprof
3 participants
@egonelbre @PandiPanda69 @aalexand