Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failing on staticcheck version #662

Closed
s-kanev opened this issue Nov 2, 2021 · 1 comment · Fixed by #664
Closed

CI failing on staticcheck version #662

s-kanev opened this issue Nov 2, 2021 · 1 comment · Fixed by #664

Comments

@s-kanev
Copy link
Contributor

s-kanev commented Nov 2, 2021

Failing on HEAD for all tip configurations (linux and macos), when trying to invoke staticcheck:

https://github.com/google/pprof/runs/4063340955

++ staticcheck github.com/google/pprof github.com/google/pprof/driver github.com/google/pprof/fuzz github.com/google/pprof/internal/binutils github.com/google/pprof/internal/driver github.com/google/pprof/internal/elfexec github.com/google/pprof/internal/graph github.com/google/pprof/internal/measurement github.com/google/pprof/internal/plugin github.com/google/pprof/internal/proftest github.com/google/pprof/internal/report github.com/google/pprof/internal/symbolizer github.com/google/pprof/internal/symbolz github.com/google/pprof/internal/transport github.com/google/pprof/profile github.com/google/pprof/third_party/d3 github.com/google/pprof/third_party/d3flamegraph github.com/google/pprof/third_party/svgpan
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
Error: Process completed with exit code 1.

It seems like a simple version issue with staticcheck -- probably because we don't use actions/setup-go@v2 in the tip configuration here and instead fetch lint tools manually.

@s-kanev
Copy link
Contributor Author

s-kanev commented Nov 2, 2021

Ah, from dominikh/go-tools#1107, the tip compiler is unsupported and not expected to work with staticcheck.

I'll just disable it in the CI then. We already do it for the latest two versions of the compiler (which are supported) anyway.

s-kanev added a commit to s-kanev/pprof that referenced this issue Nov 2, 2021
staticcheck only supports the latest 2 copmiler releases.

Fixes google#662.
s-kanev added a commit to s-kanev/pprof that referenced this issue Nov 2, 2021
staticcheck only supports the latest 2 copmiler releases.

Fixes google#662.
aalexand pushed a commit that referenced this issue Nov 2, 2021
* ci: Disable staticcheck on tip-of-tree compiler.

staticcheck only supports the latest 2 copmiler releases.

Fixes #662.

* Set RUN_STATICCHCECK for subsequent steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant