-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symbolz: skip un-symbolizable mappings #340
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 66.54% 66.52% -0.02%
==========================================
Files 36 36
Lines 7446 7448 +2
==========================================
Hits 4955 4955
- Misses 2089 2090 +1
- Partials 402 403 +1
Continue to review full report at Codecov.
|
internal/symbolz/symbolz.go
Outdated
@@ -45,6 +45,10 @@ func Symbolize(p *profile.Profile, force bool, sources plugin.MappingSources, sy | |||
// Only check for HasFunctions as symbolz only populates function names. | |||
continue | |||
} | |||
// Skip well-known system mappings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc for the function should be updated.
You also have to sign the CLA. |
This fixes google#339 by skipping attempts to symbolize anything from system mappings like [vdso], [vsyscall], etc.
I've been through the CLA process a couple years ago and somehow it got lost. Unfortunately going through it again may take some days of clearance with my company's legal team etc. I was under the understanding that for "trivial bug fix" patches like this, CLAs aren't necessary? |
I don't know if there is an exemption from CLA based on the patch size, it's not in my domain of expertise so I have to merely follow the automated CLA pre-submit check and can't merge PRs with that check failed. |
@toddlipcon Do you plan to proceed with signing the CLA? I guess alternatively I can just make the fix myself if you are fine with that. |
Sure, I'm fine with that. Sorry for radio silence, on PTO.
…On Sat, Apr 7, 2018, 9:13 AM Alexey Alexandrov ***@***.***> wrote:
@toddlipcon <https://github.com/toddlipcon> Do you plan to proceed with
signing the CLA? I guess alternatively I can just make the fix myself if
you are fine with that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#340 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA3N-jX_MKsQOgM5stRP-3pmvDj8cVoks5tmQ-_gaJpZM4S2Ksw>
.
|
Superseded by #368. |
This fixes #339 by skipping
attempts to symbolize anything from system mappings like [vdso],
[vsyscall], etc.