Handle 64-bit negative addresses when adjusting them. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#280. 64-bit addresses with the high bit set should be adjustable as long as the offset does not overflow the result. This change supersedes google#396 avoiding `math/big` dependency.
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=========================================
+ Coverage 67.67% 67.7% +0.03%
=========================================
Files 36 36
Lines 7535 7544 +9
=========================================
+ Hits 5099 5108 +9
Misses 2031 2031
Partials 405 405
Continue to review full report at Codecov.
|
nolanmar511
approved these changes
Jul 9, 2018
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
Fixes google#280. 64-bit addresses with the high bit set should be adjustable as long as the offset does not overflow the result. This change supersedes google#396 avoiding `math/big` dependency.
aalexand
added a commit
to aalexand/pprof
that referenced
this pull request
Oct 18, 2024
We added skipping unsymbolizable mappings in symbolz long time ago in PR google#368 to address google#339 where we saw error like "unexpected negative adjusted address". But that error was fixed in a more proper way in subsequent google#397 to fix another reported issue google#280 (and internal b/32020573). So skipping unsymbolized mappings shouldn't be needed anymore. I tested this by verifying that the test case from google#339 still works fine with the proposed change. And that it does fail if I roll back google#397 locally. This change is useful as we experiment with using symbolz to symbolize JIT locations from //anon (which is unsymbolizable per current terminology).
aalexand
added a commit
that referenced
this pull request
Oct 23, 2024
We added skipping unsymbolizable mappings in symbolz long time ago in PR #368 to address #339 where we saw error like "unexpected negative adjusted address". But that error was fixed in a more proper way in subsequent #397 to fix another reported issue #280 (and internal b/32020573). So skipping unsymbolized mappings shouldn't be needed anymore. I tested this by verifying that the test case from #339 still works fine with the proposed change. And that it does fail if I roll back #397 locally. This change is useful as we experiment with using symbolz to symbolize JIT locations from //anon (which is unsymbolizable per current terminology). Co-authored-by: Maggie Nolan Edmonds <nolanmar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280. 64-bit addresses with the high bit set should be adjustable
as long as the offset does not overflow the result. This change
supersedes #396 avoiding
math/bigdependency.