-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhtml: reenable sort option for flamegraphs #491
Conversation
This sorts flamegraph elements lexographiaclly such that two similar profiles can be compared side-by-side to eyeball differences in flamegraph profile shapes and sizes.
I know there are differing opinions for whether the flame graph should be sorted by total value for each node, or whether it should be sorted by function name (mainly depending on the use case), but it looks like the order of nodes now is random. This change strikes me as positive (especially given that profile comparison is not supported in pprof's flame graph view). @aalexand or @kalyanac -- This change LGTM, but I'll let either of you decide if this should be approved and merged, |
@nolanmar511 Yes, I think the change is an improvement. I am not sure whether this implementation of the flame graph is capable of sorting by the total value, but whatever sorting is better than no sorting. Something is up with the CI tests though: looks like Travis CI is going to fail with
which we need to fix and looks like AppVeyor build didn't start at all. |
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=========================================
+ Coverage 67.1% 67.1% +<.01%
=========================================
Files 37 37
Lines 7602 7603 +1
=========================================
+ Hits 5101 5102 +1
Misses 2097 2097
Partials 404 404
Continue to review full report at Codecov.
|
This sorts flamegraph elements lexographiaclly such that two similar profiles can be compared side-by-side to eyeball differences in flamegraph profile shapes and sizes.
This sorts flamegraph elements lexicographically such that two similar profiles can be compared side-by-side to eyeball differences in flamegraph profile shapes and sizes.
Flamegraph elements prior to #367 were sorted, but since then, it has been difficult to eyeball 2 similar profiles side-by-side, as the elements appear in a somewhat random order.
Before sorting profile comparison:
After sorting profile comparison: