profile.CheckValid should return an error if location has a line with empty function #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 37 37
Lines 7611 7613 +2
=======================================
+ Hits 5104 5106 +2
Misses 2103 2103
Partials 404 404
Continue to review full report at Codecov.
|
aalexand
reviewed
Apr 3, 2020
profile/profile.go
Outdated
| @@ -402,6 +402,8 @@ func (p *Profile) CheckValid() error { | |||
| if f.ID == 0 || functions[f.ID] != f { | |||
| return fmt.Errorf("inconsistent function %p: %d", f, f.ID) | |||
| } | |||
| } else { | |||
| return fmt.Errorf("profile has nil function in location line") | |||
There was a problem hiding this comment.
Can we include any context in the error message that will help triage the error?
aalexand
reviewed
Apr 3, 2020
profile/profile.go
Outdated
| @@ -402,6 +402,8 @@ func (p *Profile) CheckValid() error { | |||
| if f.ID == 0 || functions[f.ID] != f { | |||
| return fmt.Errorf("inconsistent function %p: %d", f, f.ID) | |||
| } | |||
| } else { | |||
| return fmt.Errorf("profile has nil function in location line") | |||
There was a problem hiding this comment.
Do the nil check first and unindent the main path.
aalexand
approved these changes
Apr 3, 2020
aalexand
reviewed
Apr 3, 2020
Labutin
changed the title
nolanmar511
approved these changes
Apr 7, 2020
NHDaly
added a commit
to NHDaly/Yggdrasil
that referenced
this pull request
Nov 13, 2020
Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504
giordano
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Nov 13, 2020
* Update pprof to latest revision Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504 * Update P/pprof/build_tarballs.jl - use a real version number Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Remove now unused `timestamp` * [pprof] Use `GitSource` Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
… empty function (google#517) * Check if location has a line with empty function * Include context in the error message that will help triage the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckValid should check that all lines in locations have non nil function pointer.