Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add observer #152

wants to merge 2 commits into from

Conversation

AirChen
Copy link

@AirChen AirChen commented Aug 9, 2020

Add Observer instance to receive all blocks.😁

@google-cla
Copy link

google-cla bot commented Aug 9, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ykjchen
Copy link
Collaborator

ykjchen commented Aug 9, 2020

@AirChen your contribution is appreciated. Before we consider this further, could you create an issue and describe why you think this feature is necessary? That would help folks evaluate whether the benefit of this feature outweighs the long term maintenance cost, and help solidify any new API.

@AirChen
Copy link
Author

AirChen commented Aug 10, 2020

@ykjchen Thanks for your advice, I will create an issue soon.

@AirChen AirChen mentioned this pull request Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants