Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public getters for isPending, isFulfilled and isRejected #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sja26
Copy link

@sja26 sja26 commented Apr 3, 2023

While writing a unit test in my app, I came across the need to assert the state of a promise. Specifically, I want to assert that a promise is pending. Currently, the isPending property has internal access. This pull request simply adds the public modifier to isPending, isFulfilled and isRejected properties of Promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant