Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privacy manifest. #226

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Add privacy manifest. #226

merged 11 commits into from
Feb 21, 2024

Conversation

ykjchen
Copy link
Collaborator

@ykjchen ykjchen commented Jan 10, 2024

#225

I don't see any documentation to add this to BUILD.bazel, so leaving it out for now.

@ykjchen ykjchen mentioned this pull request Jan 10, 2024
Closed
chuckhays
chuckhays approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@chuckhays chuckhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ncooke3
ncooke3 reviewed Jan 10, 2024
View reviewed changes
PromisesObjC.podspec Outdated Show resolved Hide resolved
ncooke3
ncooke3 reviewed Jan 10, 2024
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
ncooke3
ncooke3 reviewed Jan 10, 2024
View reviewed changes
PromisesSwift.podspec Outdated Show resolved Hide resolved
ykjchen and others added 4 commits January 10, 2024 11:46
@ykjchen @ncooke3
Include privacy manifest using resource_bundle rather than resource.
edcbab4 
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
@ykjchen @ncooke3
Use .process instead of .copy to include privacy manifest in Package.…
81ebda2 
…swift.

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
@ykjchen @ncooke3
Use resource_bundle instead of resource to include privacy manifest.
00c6655 
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
@ykjchen
Add privacy manifest as a resource to Promises target in Package.swift.
e9d33ea
@maurovc maurovc mentioned this pull request Jan 12, 2024
Merged
This was referenced Jan 12, 2024
Merged
Merged
Closed
@ykjchen
Copy link
Collaborator Author

ykjchen commented Jan 18, 2024

Just waiting on internal approvals before merging.

@dsafronov01 dsafronov01 mentioned this pull request Jan 23, 2024
Merged
@ncooke3
Copy link
Member

ncooke3 commented Jan 26, 2024

Hi @ykjchen, there's one more fix to be merged into this branch: ykjchen#2

@percival888 percival888 mentioned this pull request Feb 6, 2024
Merged
This was referenced Feb 8, 2024
Closed
Closed
@nabs-m
Copy link

nabs-m commented Feb 14, 2024

Any blockers left for this one? Trying to gauge when we can start consuming this in our app.

@ykjchen
Copy link
Collaborator Author

ykjchen commented Feb 16, 2024

Internal processes still in progress, I'll bump the owners to see what the status is.

@ykjchen ykjchen merged commit f28d58a into google:master Feb 21, 2024
9 of 10 checks passed
@ykjchen ykjchen deleted the privacy branch February 21, 2024 17:41
@LydGol90 LydGol90 mentioned this pull request Feb 27, 2024
Closed
@julianlocke julianlocke mentioned this pull request Mar 15, 2024
Merged
@TMaszko TMaszko mentioned this pull request Mar 25, 2024
Merged
4 tasks
This was referenced Apr 11, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

@nabs-m nabs-m nabs-m approved these changes

@chuckhays chuckhays chuckhays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykjchen @ncooke3 @nabs-m @chuckhays