Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable configuration cache test #467

Merged

Conversation

voidzcy
Copy link
Collaborator

@voidzcy voidzcy commented Feb 10, 2021

The osdetector plugin version 1.7.0 now should be compliant with configuration cache. So removing flags for ignoring configuration cache problems in tests. Java build is fully compliant. Android build still has one problem, but the problem seems to be on the AGP side.

Configuration cache problems found in this build.

1 problem was found storing the configuration cache.
- Plugin 'com.android.internal.application': registration of listener on 'TaskExecutionGraph.addTaskExecutionListener' is unsupported
  See https://docs.gradle.org/6.7/userguide/configuration_cache.html#config_cache:requirements:build_listeners

Caused by: org.gradle.api.InvalidUserCodeException: Listener registration 'TaskExecutionGraph.addTaskExecutionListener' by org.gradle.execution.taskgraph.DefaultTaskExecutionGraph@55581730 is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onBuildScopeListenerRegistration(ConfigurationCacheProblemsListener.kt:88)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:398)
	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:380)
	at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:61)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast$ListenerDispatch.dispatch(DefaultListenerManager.java:368)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast.dispatch(DefaultListenerManager.java:179)
	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast.dispatch(DefaultListenerManager.java:153)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy22.onBuildScopeListenerRegistration(Unknown Source)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph.notifyListenerRegistration(DefaultTaskExecutionGraph.java:265)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph.addTaskExecutionListener(DefaultTaskExecutionGraph.java:221)

So still keep org.gradle.unsafe.configuration-cache-problems=warn for Android build test.

@voidzcy
Copy link
Collaborator Author

voidzcy commented Feb 10, 2021

Update: AGP's issue seems have been fixed in newer releases. Use 4.2.0-beta04 (which is the newest 4.2 release) and we can fully get rid of all conf cache problems.

@voidzcy
Copy link
Collaborator Author

voidzcy commented Feb 10, 2021

It turns out build-tool 30.0.2 hasn't been officially released for Travis. So lower AGP version to 4.2.0-alpha10, it can also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants