Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IDEA support work out of the box #506

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Make IDEA support work out of the box #506

merged 1 commit into from
Jun 17, 2021

Conversation

oehme
Copy link
Contributor

@oehme oehme commented Jun 17, 2021

Instead of requiring users to apply the idea plugin, which is normally
not necessary when using IDEA's importer.

Fixes #474

@oehme
Make IDEA support work out of the box
f3c9aba 
Instead of requiring users to apply the `idea` plugin, which is normally
not necessary when using IDEA's importer.

Fixes google#474
ejona86
ejona86 approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this code is just older from before your approach was available or standard.

@ejona86 ejona86 merged commit 0e24de2 into google:master Jun 17, 2021
@ejona86
Copy link
Collaborator

ejona86 commented Jun 17, 2021

@oehme, thank you!

@voidzcy voidzcy mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated source folder should be registered on the SourceSet
2 participants
@oehme @ejona86