Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration caching when generating jar plugin trampoline script #509

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix configuration caching when generating jar plugin trampoline script #509

merged 1 commit into from
Jun 21, 2021

Conversation

ALikhachev
Copy link
Contributor

Fixes #508

@ALikhachev
Use ProjectLayout to get build directory in GenerateProtoTask
da47435 
Accessing build directory through Task.project is incompatible with Gradle configuration caching.
@ALikhachev ALikhachev changed the title Fix configuration caching for generating jar plugin trampoline script Fix configuration caching when generating jar plugin trampoline script Jun 19, 2021
voidzcy
voidzcy approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ejona86 ejona86 merged commit 5d0d5ad into google:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@voidzcy voidzcy voidzcy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Configuration cache] GenerateProtoTask uses project at execution time
3 participants
@ALikhachev @voidzcy @ejona86