-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourceFiles should ignore empty dirs #530
Conversation
This PR builds on #531, so it should only contain adding the annotation in the end. |
82400ab
to
92bc05a
Compare
Empty directories should not matter for source files, so let's ignore them for up-to-date checks as well.
92bc05a
to
5f3df49
Compare
@ejona86 This is ready for review now. Please take a look. |
What is the harm if it doesn't? |
The harm is two fold:
|
Thanks! I included those notes in the commit message. |
@ejona86 Awesome, thank you for the quick turnaround! Any idea when you have time to publish a release of the plugin including this changes? |
I was going to give some time to see if #523 can make it into the release. I was expecting to do the release early next week. |
The
GenerateProto
task only relies on source files, so it should ignore empty directories. Gradle 6.8 introduced theIgnoreEmptyDirectories
annotation, which allows declaring that.In this PR, I add the
IgnoreEmptyDirectories
annotation toGenerateProto.sourceFiles
.