Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server example #17

Merged
merged 9 commits into from
Apr 25, 2020
Merged

Server example #17

merged 9 commits into from
Apr 25, 2020

Conversation

AlexeyDer
Copy link
Contributor

Add server example that serves badges

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AlexeyDer
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@brianquinlan brianquinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contribution!

If you make the fixes that I suggested then I'd be happy to merge.

But this would be even better if:

  1. you created a requirements.txt (https://pip.pypa.io/en/stable/user_guide/#requirements-files)
  2. you created a README.md in this directory explaining how to run the server and access the resulting image.

server-example/app.py Outdated Show resolved Hide resolved
server-example/app.py Outdated Show resolved Hide resolved
server-example/app.py Outdated Show resolved Hide resolved
server-example/app.py Outdated Show resolved Hide resolved
server-example/requirements.txt Outdated Show resolved Hide resolved
server-example/requirements.txt Outdated Show resolved Hide resolved
server-example/app.py Outdated Show resolved Hide resolved
server-example/app.py Outdated Show resolved Hide resolved
server-example/README.md Outdated Show resolved Hide resolved
server-example/README.md Outdated Show resolved Hide resolved
server-example/README.md Outdated Show resolved Hide resolved
@AlexeyDer AlexeyDer requested a review from brianquinlan April 24, 2020 17:34
Copy link
Collaborator

@brianquinlan brianquinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, feel free to merge!

If you wanted, you could file an issue to add tests to this example and then write them ;-)

AlexeyDer added a commit to AlexeyDer/pybadges that referenced this pull request Apr 25, 2020
@AlexeyDer AlexeyDer requested a review from brianquinlan April 25, 2020 09:23
@brianquinlan brianquinlan merged commit a50a3e9 into google:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants