Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert(PyGILState_Check()) in gil_scoped_release constructor. #30067

Closed
wants to merge 1 commit into from
Closed

Add assert(PyGILState_Check()) in gil_scoped_release constructor. #30067

wants to merge 1 commit into from

Conversation

rwgk
Copy link
Contributor

@rwgk rwgk commented Oct 5, 2023

Description

Safety guard, to prevent undefined behavior (in the general sense).

Suggested changelog entry:



    

  
  



      


          

          
  

    
  
    
    

  

  




          

        
      




  





       
            



      

  
        





      

  
      



  

  @rwgk





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      

      
            rwgk
  

      

      

      commented


        Oct 12, 2023


      
    


  





      


        


  
    

      
          
This one-line change is included in pybind/pybind11#4877.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @rwgk
rwgk




            closed this


      Oct 12, 2023

    

  


    


  

  
  

  
      @rwgk
  rwgk


    
    deleted the
    
      
        scoped_gil_release_gil_check_pywrapcc
    
    branch

    October 12, 2023 04:37    
    













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      

        
          

            
    

    Development
  



              


Successfully merging this pull request may close these issues.



  


        
      

    

  


      

    

  
      

  

    

      1 participant
    

    

        
          @rwgk