device.Pull return {TypeError}coercing to Unicode: need string or buffer, file found

[evoup]

use python2.7
device.Pull(file_name, dest_file)
return {TypeError}coercing to Unicode: need string or buffer, file found

And I must use follow way to get work around:

    file_bytes = device.Pull(file_name)
    output_file = open(dest_file, "wb")
    output_file.write(file_bytes)
    output_file.close()

[fahhem]

Is this on Windows?

[evoup]

linuxmint

[fahhem]

Try master as of now? Okay, then 'b' also affects the expected type in write() instead of just the way the file is opened on Windows

[evoup]

Sorry, I`ve changed code in /usr/local/lib/python2.7/dist-packages/adb/adb_commands.py 294 line then add a 'b', and regenrate the adb_commands.pyc file, but return same error after run code.

[fahhem]

Hmm, what type is dest_file when you pass it into Pull? Is it the filename (a string) or an open file?

[evoup]

Sorry, it is my fault. May be lost object bug in my code, can pull picture now. And it does not matter with 'b'.Thanks for your help!

[fahhem]

Does it work with 'b' though? I think it's necessary for Windows, so if it works in Linux then I'll leave that change

[evoup]

Yes, both add 'b' or without 'b' , can work in my linux

[evoup]

HI:
I think I still find the problem after some debuging test, I assign dest_file param with '/tmp/1.png'.
The reason is calling

dest_file.close()
return os.path.exists(dest_file)

which dest_file is type:

<closed file '/tmp/1.png', mode 'w' at 0x7f0b50528e40>
<type 'file'>

so if we call os.path.exists(dest_file) , the param dest_file type should be string or buffer, it is file so get the exception

[fahhem]

How about with that commit? 82bfd52

[evoup]

Tested ok, even if remove

elif isinstance(dest_file, file):
    pass