adding code to support optional type abbreviation request #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@googlebot Could you please submit a rescan for the CLA? Thanks! |
genos
reviewed
Jan 24, 2022
genos
reviewed
Jan 24, 2022
damienjburks
force-pushed
the
issue-329
branch
from
2d4c679 to
e6b2d8e
Compare
PiperOrigin-RevId: 379999792 Change-Id: I2594db4540cfe20820951bae479d16c167ba391a adding code to support optional type appreviation request Author: Damien Burks <damien@damienjburks.com> committing latest changes for supporting python 3.9+
damienjburks
force-pushed
the
issue-329
branch
from
e6b2d8e to
b1d4e45
Compare
Signed-off-by: Damien Burks <damien@damienjburks.com>
genos
reviewed
Jan 25, 2022
|
Added that adjustment. I wasn't aware that Union could have more than 2 options, so that you for the recommendation @genos |
|
Thanks for the contribution! This looks good. |
|
@dbieber it supports python versions 3.x and up. I have not tested this with any of the python 2 versions. Let me know if this is an issue. |
|
We don't need the improvement to apply to Python 2, but we do need to make sure we don't break fire for Python 2.7. |
|
@dbieber I will check into this, and attach my results to this issue. Thanks. |
dbieber
changed the title
vincentkoc
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #329