Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive mode: Mention IPython REPL requirement #383

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

gruberma
Copy link
Contributor

@gruberma gruberma commented Feb 3, 2022

Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the source file.

Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the [source file](https://github.com/google/python-fire/blob/master/fire/interact.py#L17).
@dbieber
Copy link
Collaborator

dbieber commented Apr 16, 2022

If you sign the CLA, happy to merge this PR.

@gruberma
Copy link
Contributor Author

Thanks for the reminder, just signed it :-)

@gruberma
Copy link
Contributor Author

Unfortunately, I'm getting a 400 error when trying to rescan the CLA. Does someone have experience with this error or could someone else please try to trigger the rescan?

grafik

@dbieber
Copy link
Collaborator

dbieber commented Apr 23, 2022

That's unexpected. https://cla.developers.google.com/ is the url for the cla -- that giving you a 404 is strange.
I'll look into how to retrigger the scan.

@dbieber
Copy link
Collaborator

dbieber commented Apr 23, 2022

That was easier than expected :)
You're all set.

@gruberma
Copy link
Contributor Author

Perfect, thanks :-)

@gruberma
Copy link
Contributor Author

Is there something else that I should do before you could merge?

@dbieber dbieber merged commit c3703f4 into google:master Dec 9, 2022
dbieber pushed a commit to wchliao/python-fire that referenced this pull request Dec 9, 2022
Mention that the ipython package is an optional requirement for using the IPython REPL, as described in the [source file](https://github.com/google/python-fire/blob/master/fire/interact.py#L17).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants