Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop host Python 3.5 support. #677

Closed
rchen152 opened this issue Sep 18, 2020 · 2 comments
Closed

Drop host Python 3.5 support. #677

rchen152 opened this issue Sep 18, 2020 · 2 comments
Assignees
@rchen152
Labels
bug

Comments

@rchen152
Copy link
Contributor

Python 3.5 reaches its end-of-life in a few weeks: https://www.python.org/downloads/release/python-3510/. Once it does, we should drop support for running pytype under 3.5 so that we can use modern features like f-strings and variable annotations.

For now, we won't deliberately break analyzing code as 3.5, but users will need two interpreters - a 3.5 one to compile bytecode for the code under analysis, and a 3.6-3.8 one to run pytype - and support will degrade over time once we remove the tests. (Of course, it's always possible to pin to an older version of pytype.)
@rchen152 rchen152 added the bug label Sep 18, 2020
@rchen152 rchen152 self-assigned this Sep 18, 2020
@rchen152 rchen152 pinned this issue Oct 9, 2020
rchen152 added a commit that referenced this issue Oct 9, 2020
@rchen152
Drop support for running pytype under Python 3.5.
2f9a1a8 
Moving off 3.5 will allow us to write code using f-strings and variable
annotations. To continue analyzing 3.5 code, users can pin to pytype
2020.10.08 or run pytype under a 3.6-3.8 interpreter and pass `-V 3.5`
to it. (For the latter option, they'll need to find some way to tell
pytype where third party packages are located, or just silence the
import errors.)

For #677.
@rchen152
Copy link
Contributor Author

rchen152 commented Oct 9, 2020

I'll leave this issue pinned for a bit for visibility. pytype 2020.10.08 is the last release that supports running pytype under Python 3.5. With the next release, you'll have to run pytype under a 3.6-3.8 interpreter and pass -V3.5 to analyze code as 3.5.

@rchen152 rchen152 closed this as completed Oct 9, 2020
rchen152 added a commit that referenced this issue Oct 12, 2020
@rchen152
Update docs to reflect removal of host 3.5 support.
17b7721 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 14, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
e24d18e 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 14, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
a9cf823 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 14, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
5bfa356 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 15, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
2f423de 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 16, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
4c203e0 
For #677.

PiperOrigin-RevId: 336207143
Solumin pushed a commit that referenced this issue Oct 19, 2020
@rchen152 @Solumin
Update docs to reflect removal of host 3.5 support.
ce2ce21 
For #677.

PiperOrigin-RevId: 336207143
@rchen152 rchen152 mentioned this issue Nov 4, 2020
Closed
@rchen152
Copy link
Contributor Author

rchen152 commented Nov 5, 2020

pytype 2020.11.03 is the first release to not support running under 3.5.

@rchen152 rchen152 unpinned this issue Nov 5, 2020
python-fire-bot pushed a commit to google/python-fire that referenced this issue Dec 16, 2020
@rchen152 @copybara-github
Don't run pytype in Python 3.5.
a938ef9 
Copybara import of the project:

--
eeef066 by Rebecca Chen <rechen@google.com>:

Don't run pytype in Python 3.5.

The next release of pytype drops support for running under Python 3.5:
google/pytype#677.

COPYBARA_INTEGRATE_REVIEW=#296 from rchen152:drop35 eeef066
PiperOrigin-RevId: 347877059
Change-Id: I8b2e8acba3d3ce3ebc47612d7f136d7a643650d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rchen152 rchen152

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rchen152