Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Dart 2 Map, Iterable, and List methods to multimap stuff #425

Merged
merged 6 commits into from
Mar 23, 2018

Conversation

srawlins
Copy link
Contributor

No description provided.

// the MapEntry class has been added.
throw new UnimplementedError("entries");
Iterable<MapEntry<K, C>> get entries {
return keys.map((K key) => new MapEntry<K, C>(key, this[key]));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

Iterable<MapEntry<K, C>> get entries => _multimap._map.entries;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

var entry = transform(key, this[key]);
result[entry.key] = entry.value;
}
return result;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  Map<K2, C2> map<K2, C2>(MapEntry<K2, C2> transform(K key, C value)) =>
      _multimap._map.map(transform);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

* master:
  Add new Dart 2 Iterable and List methods (google#422)
  Document google#373 as breaking change (google#424)
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@cbracken cbracken merged commit 520ee76 into google:master Mar 23, 2018
srawlins added a commit to srawlins/quiver-dart that referenced this pull request Mar 23, 2018
* master:
  Add new Dart 2 Map methods to BiMap (google#423)
  Add new Dart 2 Map, Iterable, and List methods to multimap stuff (google#425)
  Add .dart_tool to gitignore (google#431)
  Update changelog for LruMap fix (google#430)
  Ensure that LruMap linkage is preserved (google#429)
  Update CHANGELOG.md (google#428)
  Update CHANGELOG/pubspec to include 0.28.1 (google#427)
@cbracken
Copy link
Member

Partial fix to #418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants