-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Dart 2 Map, Iterable, and List methods to multimap stuff #425
Conversation
lib/src/collection/multimap.dart
Outdated
// the MapEntry class has been added. | ||
throw new UnimplementedError("entries"); | ||
Iterable<MapEntry<K, C>> get entries { | ||
return keys.map((K key) => new MapEntry<K, C>(key, this[key])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps:
Iterable<MapEntry<K, C>> get entries => _multimap._map.entries;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/src/collection/multimap.dart
Outdated
var entry = transform(key, this[key]); | ||
result[entry.key] = entry.value; | ||
} | ||
return result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map<K2, C2> map<K2, C2>(MapEntry<K2, C2> transform(K key, C value)) =>
_multimap._map.map(transform);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* master: Add new Dart 2 Iterable and List methods (google#422) Document google#373 as breaking change (google#424)
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
* master: Add new Dart 2 Map methods to BiMap (google#423) Add new Dart 2 Map, Iterable, and List methods to multimap stuff (google#425) Add .dart_tool to gitignore (google#431) Update changelog for LruMap fix (google#430) Ensure that LruMap linkage is preserved (google#429) Update CHANGELOG.md (google#428) Update CHANGELOG/pubspec to include 0.28.1 (google#427)
Partial fix to #418. |
No description provided.