Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(|a)* matches more text than (|a)+ does #310

Closed
junyer opened this issue May 12, 2021 · 1 comment
Closed

(|a)* matches more text than (|a)+ does #310

junyer opened this issue May 12, 2021 · 1 comment

Comments

@junyer
Copy link
Contributor

junyer commented May 12, 2021

As per golang/go#46123 and rust-lang/regex#779, (|a)* matches more text than (|a)+ does. We have agreed to fix this across RE2, the Go regexp package and the Rust regex crate. (RE2/J will hopefully follow suit without much badgering...)
@junyer
Copy link
Contributor Author

junyer commented May 12, 2021

Oh, hah. google/re2j#136 was filed just a few minutes before this issue was filed. :)

copybara-service bot pushed a commit that referenced this issue May 12, 2021
@junyer
(|a)* shouldn't match more text than (|a)+ does!
8f8778a 
Fixes #310.

Change-Id: I16c500e4b4c67a9f01dc9403773f3a40356ecc4d
Reviewed-on: https://code-review.googlesource.com/c/re2/+/58590
Reviewed-by: Paul Wankadia <junyer@google.com>
(cherry picked from commit bc42365)
Reviewed-on: https://code-review.googlesource.com/c/re2/+/58591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@junyer