-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using absl logging. #494
Comments
Thanks for the nudge. I had indeed been wanting to switch to Abseil logging for quite some time, but hadn't found the motivation to deal with the fact that Ubuntu (as used in our CI workflows) ships very old versions of Abseil. ;) |
Fixes #494. Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
Fixes #494. Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
I could make an argument that CI shouldn't depend on the version of anything shipped on the host. ... That said, I'll try to not jostle your elbow while your doing that thin I asked for. ;0) |
My life would probably be a lot simpler if RE2 could get away with supporting Bazel only, but... |
It would be nice to either replace RE2's "Simplified version of Google's logging" with ABSL logging or provide an option to switch to that.
More than half the uses of
util/logging.h
are in files that already depend on ABSL which has had a full copy of glog for nearly two years. The only feature that RE2's logging seems to implement that I'm not seeing in ABSL isVLOG
. It looks like a full switch over would be almost trivial, assuming the version dependency is allowable.The text was updated successfully, but these errors were encountered: