Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Modernize the tool #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modernize the tool #12

wants to merge 6 commits into from

Conversation

vibhoothi
Copy link

This is small refactoring and improvement work I did a few months back, I guess it will be useful for R&D,

Things changed

  • Use sha1sum instead of shasum
  • Using master instead of old hashed version
  • Introduce AV1 encoder and decoder
    • rav1e
    • dav1d

This commit makes
- Checkout to latest master
- Remove broken feature flag
This commit makes
- Build av1 of master
- Building cleaner
This is in favour of making the builds more generic which unbreaks for macOS
This Commit introduces dav1d, smallest and fastest AV1 Decoder
This commit introduces rav1e, the AV1 Encoder
- Encoding is happening at default speed level(6)
- Decoding is done with the help of dav1d
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pbos
Copy link
Contributor

pbos commented Jul 6, 2020

Hi, added some feedback re using master directly. Could you split this into three or four pull requests as they seem independent to me?

  • Updating the current revision (and removing the expired flag), but to a specific recent hash and not "master"?
  • Optional separate: Add a --revision flag to setup.sh to pull down a different version than the pinned hash.
  • Using sha1sum instead of shasum
  • Adding the AV1 encoder/decoder pair.

@@ -23,8 +23,8 @@ fi
# Check out the pinned libvpx version.
pushd libvpx
git fetch
git checkout --detach e758f9d45704ea0247c1b654f8602c967fa44199
git checkout --detach master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the previous tagged commit is intentional, that way two checkouts get the same version of the library they're comparing. Unfortunately that hash is ancient since I stopped working on this.

If you want to you can update the hash to the current master (so that you can remove the spatial-svc flag below). You can also add a --revision command-line flag so that you could run ./setup.sh --revision=master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants