Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts testing with ICU 67.1 #78

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

filmil
Copy link
Member

@filmil filmil commented May 8, 2020

This is the last step in getting rust_icu tested with ICU 67.1 There
are a few pull requests in flight that preempt this one, such as #75,
but once those are commited, this can go in. (And should pass.)

Fixes #76.

@filmil filmil requested a review from kpozin May 8, 2020 08:18
@filmil
Copy link
Member Author

filmil commented May 8, 2020

This also requires build, tag, and push of the appropriate test docker images.

@filmil filmil force-pushed the use-buildenv-67 branch 2 times, most recently from fd13ef2 to 6e7ef8e Compare May 8, 2020 20:01
This is the last step in getting rust_icu tested with ICU 67.1  There
are a few pull requests in flight that preempt this one, such as google#75,
but once those are commited, this can go in. (And should pass.)

Fixes google#76, google#83
@filmil filmil merged commit 0850dd1 into google:master May 8, 2020
@filmil filmil deleted the use-buildenv-67 branch September 17, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start testing rust_icu with ICU 67.1
2 participants