-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is googletest optional or not? #67
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Readme says
Despite this, the
s2testing
library is included in the build unconditionally, which in turn includes the files2shapeutil_testing.cc
, which includesgtest/gtest.h
.So it seems to me that googletest is required in practice. I'm not sure if the readme just needs to be updated to say that googletest is required or if the
s2testing
library should be included in the conditional test block.The text was updated successfully, but these errors were encountered: