Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is googletest optional or not? #67

Closed
jason-watkins opened this issue Apr 4, 2019 · 3 comments
Closed

Is googletest optional or not? #67

jason-watkins opened this issue Apr 4, 2019 · 3 comments

Comments

@jason-watkins
Copy link

The Readme says

Requirements for End Users

  • ...
  • googletest testing framework (to build tests and example programs, optional)

Despite this, the s2testing library is included in the build unconditionally, which in turn includes the file s2shapeutil_testing.cc, which includes gtest/gtest.h.

So it seems to me that googletest is required in practice. I'm not sure if the readme just needs to be updated to say that googletest is required or if the s2testing library should be included in the conditional test block.
@jmr
Copy link
Member

jmr commented Apr 6, 2019

It's a bug.

@hpolloni
Copy link

hpolloni commented Aug 4, 2019

PR: #78

@figroc
Copy link

figroc commented Nov 21, 2019

@jmr #78 has been updated with CLA signed. Would you kindly give a review?

@figroc figroc mentioned this issue Nov 21, 2019
Open
@jmr jmr mentioned this issue Mar 21, 2022
Merged
jmr pushed a commit that referenced this issue Mar 21, 2022
@MBkkt
Make GTEST_ROOT optional (#236)
f3ed5e0 
Fixes #234, #179, #100, #67.
@jmr jmr closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hpolloni @jmr @jason-watkins @figroc