build library and also Python wheels in CI

[zacharyburnett]

closes #389

attempt to use pypa/cibuildwheel pypa/build to build wheels for Linux, macOS, and Windows

EDIT: also run cmake and make install in another job to test the build

[jmr]

Thanks for trying this. I authorized and triggered the workflows. They all fail.

https://github.com/google/s2geometry/actions/runs/11724915532/job/32662569678?pr=390

Getting action download info
Error: Unable to resolve action `actions/checkout@v5`, unable to find version `v5`

Doesn't this also need to do something to install the dependencies like abseil-cpp?

[zacharyburnett]

Thanks for trying this. I authorized and triggered the workflows. They all fail.

https://github.com/google/s2geometry/actions/runs/11724915532/job/32662569678?pr=390

Getting action download info
Error: Unable to resolve action `actions/checkout@v5`, unable to find version `v5`

oof, I always forget it only has v4 😅 I'll just pin it to a specific release

Doesn't this also need to do something to install the dependencies like abseil-cpp?

oh yes, I forgot about abseil

[jmr]

oof, I always forget it only has v4 😅 I'll just pin it to a specific release

Can you use v4 instead of v5? Or not specify a version? Why is a hash better?

I triggered it again for another batch of failures.

[zacharyburnett]

oof, I always forget it only has v4 😅 I'll just pin it to a specific release

Can you use v4 instead of v5? Or not specify a version? Why is a hash better?

it's better to use a commit hash for security, because if someone takes control of the upstream action repo they could theoretically retag an existing tag to point to malicious code

It's not a pressing issue though, so we could just change it to v4 here, you're right

[zacharyburnett]

thank you for being so patient as I iterate on this workflow! I'm attempting to make it easier to obtain wheels for s2geometry such that we could maybe use this downstream as a backend for our spherical_geometry package

[jmr]

I ran it again.

[zacharyburnett]

I'm able to run actions on my fork: https://github.com/zacharyburnett/s2geometry/actions

I'll try to get this running

[jmr]

Install the project...
-- Install configuration: ""
CMake Error at absl/base/cmake_install.cmake:46 (file):
  file cannot create directory: /usr/local/lib/pkgconfig.  Maybe need
  administrative privileges.
Call Stack (most recent call first):
  absl/cmake_install.cmake:47 (include)
  cmake_install.cmake:47 (include)

You probably need -DCMAKE_INSTALL_PREFIX=... for abseil-cpp.

I use -DCMAKE_PREFIX_PATH=/tmp/absl-install-17 -DCMAKE_INSTALL_PREFIX=/tmp/absl-install-17 -DABSL_ENABLE_INSTALL=ON -DBUILD_TESTING=off -DCMAKE_VERBOSE_MAKEFILE=on -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_CXX_STANDARD=17, but I'm not sure how many of these are really needed.

Then build s2geometry with -DCMAKE_PREFIX_PATH=/tmp/absl-install-17.

[zacharyburnett]

Install the project...
-- Install configuration: ""
CMake Error at absl/base/cmake_install.cmake:46 (file):
  file cannot create directory: /usr/local/lib/pkgconfig.  Maybe need
  administrative privileges.
Call Stack (most recent call first):
  absl/cmake_install.cmake:47 (include)
  cmake_install.cmake:47 (include)

You probably need -DCMAKE_INSTALL_PREFIX=... for abseil-cpp.

I use -DCMAKE_PREFIX_PATH=/tmp/absl-install-17 -DCMAKE_INSTALL_PREFIX=/tmp/absl-install-17 -DABSL_ENABLE_INSTALL=ON -DBUILD_TESTING=off -DCMAKE_VERBOSE_MAKEFILE=on -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_CXX_STANDARD=17, but I'm not sure how many of these are really needed.

Then build s2geometry with -DCMAKE_PREFIX_PATH=/tmp/absl-install-17.

ah, thank you! I apologize, I'm not familiar with building C++ at all, so I appreciate your help

[zacharyburnett]

from testing on the fork, the cmake job seems to succeed building now, but the cibuildwheel still fails:

[jmr]

How do you make cibuildwheel show the cmake output? I can't see why it failed.

https://github.com/google/s2geometry/actions/runs/11747466338/job/32729571493?pr=390

[jmr]

https://github.com/google/s2geometry/actions/runs/11747466338/job/32729571493?pr=390#step:4:505

The s2geometry cmake needs to be pointed at where abseil-cpp was installed.

something happened to CMAKE_PREFIX_PATH

https://github.com/google/s2geometry/actions/runs/11747466338/job/32729571493?pr=390#step:4:473

[jmr]

nproc doesn't exist on macOS. sysctl -n hw.physicalcpu or logicalcpu is the equivalent.

[zacharyburnett]

so I've been QUITE dumb 😅

All this time I've been trying to recreate cibuildwheel's functionality because I didn't know how to include the built version of abseil-cpp in the container, BUT I neglected to realize that I could have just been installing it with yum and brew (see #390 (comment)). I'm testing with cibuilwheel now, with a before-all command to install the requisite libraries in the config

[zacharyburnett]

taking this back into draft until I can figure out the magic config for cibuildwheel that'll work

[jmr]

Ok, thanks for working so hard on this.