Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in the latest safety-web development #4

Merged
merged 33 commits into from
Jul 25, 2024
Merged

Pull in the latest safety-web development #4

merged 33 commits into from
Jul 25, 2024

Commits on Jul 9, 2024

  1. Add a base skeleton for the plugin 

    Change-Id: I7e98fdf3aa147ca8c1e14eb0f2bbf508aa610f60
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8f46c03 View commit details
    Browse the repository at this point in the history

  2. Set up Mocha with a placeholder test 

    Change-Id: I2f31bcf5f868c237417f17a75dc58d0e62438fba
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    245e69e View commit details
    Browse the repository at this point in the history

  3. Remove tests from tsconfig and add yarn clean script 

    Change-Id: I1455d874fd158a5e915e48c4d1a57de40b37cbf2
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5e93a0b View commit details
    Browse the repository at this point in the history

  4. Add Copyright header to js files 

    Change-Id: Ib3f5a77d4b36e21b40413092dc42ddf135b30378
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bb4ba4c View commit details
    Browse the repository at this point in the history

  5. Add a notice that safety-web is under development 

    Change-Id: Idd3d9458d2682560d9b9534a87203aa34ac3ba68
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    880d07c View commit details
    Browse the repository at this point in the history

  6. Sets the rule tester up 

    Change-Id: I14e9dfd64aea1b8262a762c3689aa07caac34d18
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0037776 View commit details
    Browse the repository at this point in the history

  7. Add a script to update a vendored version of tsetse and add the curre… 

    …nt version of tsetse

Change-Id: I542eafad8b6570612592af12f43041c7767fc921
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0cc2d3f View commit details
    Browse the repository at this point in the history

  8. Track the last run of the tsetse_update.sh script and the latest comm… 

    …it pulled for tsetse

Change-Id: Ice0292972ac65701676e34289688dd03d110cb37
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ef0c259 View commit details
    Browse the repository at this point in the history

  9. Add readme instructions for updating tsetse 

    Change-Id: I541078c4ff8cb51f177f6e73242c0637db47aa2b
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ba5fd67 View commit details
    Browse the repository at this point in the history

  10. Add dependencies for tsetse 

    Change-Id: If68828cde13c7a70276115493e6d311cf489aad8
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2d0362a View commit details
    Browse the repository at this point in the history

  11. Wire the tsetse checks, update the tests and test fixtures 

    This implementation is taken from the tsec eslint plugin. It only works with projects that have a tsconfig setup.

Change-Id: Ia8c000f96e10ec0a91e9c232af47fee72e590b53
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e49f7f5 View commit details
    Browse the repository at this point in the history

  12. Add a test project as an integration test 

    Change-Id: I8b39d9537ca903b26f2a2758ac9c50d3054364df
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0ef5c49 View commit details
    Browse the repository at this point in the history

  13. Add a test helper to check for expected violations 

    WIP: this helper will be refined to focus on certain fields and make the test less rigid.
Change-Id: I5b0f64c6b52f7b89b7e94bd5c5fbf62af709097b
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f0a6559 View commit details
    Browse the repository at this point in the history

  14. Add a JavaScript test project as an integration test 

    Change-Id: I4031da14bad7d9d4b8999727e81bd0178b33067c
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    afca3ca View commit details
    Browse the repository at this point in the history

  15. Set ESLint up for safety-web sources 

    Change-Id: Ieff5925cfd6ecfbc314dd69ad3d077cab0320ae1
    @neuracr
    neuracr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c2119c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Fix the lint issues in safety-web 

    Change-Id: Ic649c4eadd8c036727e7f71af8a1368878d0a4bc
    @neuracr
    neuracr committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    57b5a9c View commit details
    Browse the repository at this point in the history

  2. Fix the main entry point path 

    Since test/ was added to the tsconfig, lib.index.js moved to lib/src/index.js. This was caught in the integration tests, but I haven't set the CI yet and I forgot to run them before the tsconfig change.

Change-Id: Id9bacc21976090270a008abcfb93c46e3ac01bdb
    @neuracr
    neuracr committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    13d4134 View commit details
    Browse the repository at this point in the history

  3. Only add compiled JS to the NPM release 

    Change-Id: Ic96d5a7e791bc0e80ea6b7ba5973a03f3a314659
    @neuracr
    neuracr committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    50653be View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Improve the violation expectation helper 

    - Canonicalize the finding reports to compare them
- Also add the license header
- Also add the javascript test project to the integration tests

Change-Id: I6eded1df866bdb0fe3a364e2834d361c67a36df1
    @neuracr
    neuracr committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a1b1d19 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Add a typescript integration test set up with ESLint8 

    There are a few breaking changes between ESLint 8 and 9 so it's worth testing that safety-web works with both versions.

Change-Id: Ic97ab5d5d7a958631cb2ef527e1748752ed2528b
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c0bf583 View commit details
    Browse the repository at this point in the history

  2. Fix the basic-typescript-eslint9 tests 

    Change-Id: Icf62c861dc3f95377e10a4474da188214dd01ce9
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3aeb2c4 View commit details
    Browse the repository at this point in the history

  3. Define common script for all packages to be able to use `yarn workspa… 

    …ces run x`

Change-Id: I4aced5d5fbe69aec917dbf52cf14bb81e2822fe4
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4b85dba View commit details
    Browse the repository at this point in the history

  4. Add a test:watch 

    Change-Id: Iba160f4b696ce2bfc2bdbd5d3b375c46cc5b865d
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a7bb661 View commit details
    Browse the repository at this point in the history

  5. Wire tsetse violations to ESLint message ids. 

    Change-Id: Ic594a1ed16102e987bb2e47b6d30d0f524134d52
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    654446f View commit details
    Browse the repository at this point in the history

  6. Add commands to update the violation golden files 

    Also explicitely use the node_module path for running eslint8 as there's a bug in yarn that makes it run the wrong binary yarnpkg/yarn#8590

Change-Id: I0ffb28f7831b8c016d1f6f00b9af9909d78647ed
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a79b037 View commit details
    Browse the repository at this point in the history

  7. Clean the javascript eslint 9 test config up 

    Change-Id: I17239dc278005c054d83b7e45599bb72205f05d9
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e661633 View commit details
    Browse the repository at this point in the history

  8. Mark the test helper binary as executable once built 

    Change-Id: I4b111226d5920c0de3ac9ff5236c68277fa5e184
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a507056 View commit details
    Browse the repository at this point in the history

  9. Add a integration for javascript running on ESLint8 

    Change-Id: Ide643796658c061627191d0e020750dd721b3cc0
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    304a8b7 View commit details
    Browse the repository at this point in the history

  10. Add a build:watch script to auto-rebuild safety-web on changes 

    Change-Id: I9a8758a69f39569181864851a7f6dff19fde9543
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6d87de7 View commit details
    Browse the repository at this point in the history

  11. Check that we're actually using eslint8 in integration test 

    yarn run eslint doesn't resolve the correct version by default. This was
already working, but was not checked.

Change-Id: I74fd24254d7ce0f17ad984668c78cf3ab869d127
    @neuracr
    neuracr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fe28c64 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Specify the yarn version to use with corepack 

    Change-Id: I55c8548c6ee85d97f7d5d71e08642178d978d704
    @neuracr
    neuracr committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6406441 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Upgrade yarn to the latest version (Berry 4.3.1) 

    Also upgrade the version of some dependencies, commands and
documentation to match the new Yarn syntax.

Change-Id: I21aaa6ba30185fc7c49b31efbcce31660fff7717
    @neuracr
    neuracr committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bfc0b81 View commit details
    Browse the repository at this point in the history

  2. Fix the project after Yarn was upgraded. 

    Change-Id: Ibcb3320de668abccb68fece5242c74913d4b36e2
    @neuracr
    neuracr committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    50e685c View commit details
    Browse the repository at this point in the history