Remove TypeScript as an explicit peer dependency. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one potential fix to google#180 that allows schema-dts to continue to be used with `import` and any/no bundlers without increasing bundle size. It is also possible to address google#180 by simply asking users to save schema-dts as a dev dependency. This is generally more correct for typings, but runs the risk of leaving dangling imports to nonexistent "schema-dts" js. We _may_ want to add TypeScript as a dev dependency instead. I'm not sure.
|
Hi @Eyas any ETA about the new release? I can't install this as dev dependencies because eslint complains about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one potential fix to #180 that allows schema-dts to continue to be used
with
importand any/no bundlers without increasing bundle size.It is also possible to address #180 by simply asking users to save
schema-dts as a dev dependency. This is generally more correct for
typings, but runs the risk of leaving dangling imports to nonexistent
"schema-dts" js.