Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shapes viewer to the demo #46

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

Gnomus042
Copy link
Collaborator

Some changes for one of the tasks in #44 - exposing shex schemas used for validation in ShExJ format.
Shapes are taken from shex.js internal representation in ShExJ, ids are extracted and shown in the list, as well as shape content when one of the shapes is selected. Here is the overview of how it would look:

image

It will be a little harder to display SHACL shapes, as to reconstruct them we need to parse the triples graph or rely on file serialization and format to fetch shapes and corresponding names, which would be unreliable. Alternatively, we can fetch used shapes from the server, for that we can put existing shapes to the DB instead of storing them in the filesystem. This will also allow exposing ShEx shapes in ShExC, which would be more readable.

Please let me know which option sounds better.

@danbri
Copy link
Contributor

danbri commented Aug 8, 2022

Fantastic—- thanks!

we have some fixes to merge in from ericP-changes. I suggest we do that first then merge in this PR.

@danbri
Copy link
Contributor

danbri commented Aug 9, 2022

@Gnomus042 does the updated package-lock.json work with this code?

@danbri
Copy link
Contributor

danbri commented Aug 9, 2022

Regarding your question I think it will be best if we can try to make it work with a simple static server as a shared base. In some contexts it makes sense to do things on server but for a default let’s try to have it work everywhere.

danbri added a commit that referenced this pull request Oct 5, 2022
incorporate #46 and fix ShapeDecls in ShEx schema
@danbri danbri merged commit f71f79b into google:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants