Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelCTF: add CVE-2023-3390_lts_cos_mitigation #40

Merged
merged 14 commits into from
Aug 29, 2023

Conversation

c0m0r1
Copy link
Contributor

@c0m0r1 c0m0r1 commented Jul 27, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@koczkatamas koczkatamas added recheck Triggers kernelCTF PR verification again and removed recheck Triggers kernelCTF PR verification again labels Aug 24, 2023
@koczkatamas
Copy link
Collaborator

Hey!

Sorry for the late response. We created a Github Actions job to verify the submission PRs.

The current test run mostly failed because of the PR's file structure issues, see my suggestions above how to resolve these. You can see the current test run results here: https://github.com/google/security-research/actions/runs/5964212828

After you fix these issues the Github Action will run again, and it will test the exploit compilation and exploit reproduction too.

The compilation failed for us with the error configure: error: Package requirements (libmnl >= 1.0.4) were not met: No package 'libmnl' found, but you will see too from the GHA logs after you fix the structure issues and rerun the GHA job.

The exploit reproduction worked for cos but failed with mitigation and lts, because they wait for [+] type any number to go!, please remove the requirement of user input from the exploits.

If the reproduction fails for some other reason too, then please take a look why it fails. The reproduction system is a bit different than the live one (it runs the exploit directly from /init and there is no nsjail). You can also give feedback how we should modify our reproduction procedure.

So feel free to modify the PR and the Github Action will run again and you will see the new verification results.

Thank you for your submission and participating in kernelCTF!

@c0m0r1
Copy link
Contributor Author

c0m0r1 commented Aug 24, 2023

Hello.
We fixed all the mentioned issues. However, It seems to require CLA from @koczkatamas, since you're the co-author of commits for fixing metadata.
Should I wait for the CLA signing from you or revert that commits?

@koczkatamas koczkatamas added the recheck Triggers kernelCTF PR verification again label Aug 24, 2023
@koczkatamas
Copy link
Collaborator

Hey!

Thanks for the changes!

I solved the CLA issue.

Sadly your exploit still does not build, so the reproduction uses the old exploit which still contains the user interaction, so the repro also fails.

I also changed the way how the Github Actions job work and hopefully you will be trigger a re-check automatically in the future when you make changes to the PR.

I now re-run the checks manually and these are the current results: https://github.com/google/security-research/actions/runs/5969023328

@koczkatamas koczkatamas merged commit b40d86c into google:master Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recheck Triggers kernelCTF PR verification again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants