Update docs: Ninja now required to build with MSVC #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiagainst
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Thanks for the doc update! Could you also update https://github.com/google/shaderc-rs/blob/master/src/lib.rs#L31?
.appveyor.yml
Outdated
| # (https://github.com/Microsoft/msbuild/issues/53), | ||
| # we use ninja to build. | ||
| # Ninja is required to build with Visual Studio because MSBuild does not | ||
| # support pathnames longer than MAX_PATH |
|
Merge hazard on #46. Looks compatible-ish |
|
Merged. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for merging #47 😄.
This PR updates the docs to take into account the changes made by that PR.
Thanks!