Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable Glslang tests when Shaderc tests are enabled #1396

Closed
dneto0 opened this issue Feb 12, 2024 · 1 comment · Fixed by #1397
Closed

enable Glslang tests when Shaderc tests are enabled #1396

dneto0 opened this issue Feb 12, 2024 · 1 comment · Fixed by #1397
Assignees
@dneto0

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Feb 12, 2024

Glslang tests are only enabled if the Cmake project is top-level.
See this change KhronosGroup/glslang@cf1fbbf
@dneto0 dneto0 self-assigned this Feb 12, 2024
dneto0 added a commit to dneto0/shaderc that referenced this issue Feb 12, 2024
@dneto0
Propagate test/install options to Glslang
7a0235c 
This needs KhronosGroup/glslang#3508
to be effective

Fixes: google#1396
@dneto0 dneto0 mentioned this issue Feb 12, 2024
Merged
@dneto0
Copy link
Collaborator Author

dneto0 commented Feb 13, 2024

KhronosGroup/SPIRV-Headers#418 would update SPIRV-Headers to allow testing and installing.

dneto0 added a commit to dneto0/shaderc that referenced this issue Apr 15, 2024
@dneto0
Propagate test/install options to Glslang
546f98c 
This needs KhronosGroup/glslang#3508
to be effective

Fixes: google#1396
dneto0 added a commit to dneto0/shaderc that referenced this issue Apr 15, 2024
@dneto0
Propagate test/install options to Glslang
cb2fea9 
Fixes: google#1396
dneto0 added a commit to dneto0/shaderc that referenced this issue Apr 16, 2024
@dneto0
Propagate test/install options to Glslang. Update Glslang
6ddea28 
A Glslang test needed an update to work around assumptions of
the sign of a NaN.

Fixes: google#1396
dneto0 added a commit that referenced this issue Apr 16, 2024
@dneto0
Propagate test/install options to Glslang. Update Glslang (#1397)
c789753 
A Glslang test needed an update to work around assumptions of
the sign of a NaN.

Fixes: #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dneto0 dneto0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate test/install options to Glslang dneto0/shaderc
1 participant
@dneto0