Missing SOVERSION

[mia-0]

On platforms like Linux, shared libraries should have a SOVERSION which states the API version of that library. This is important if you want distros to pick up any of your libraries.

To do this, simply add a line like this in libshaderc/CMakeLists.txt:

set_target_properties(shaderc_shared PROPERTIES SOVERSION 1)

where 1 is the API version.

See also: https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html

[haasn]

Related to #381

[mia-0]

Come on people, you just have to decide on an API version and increment it every time you break API. Oh right, you’d have to care about users other than Google. Shucks.

[eclipseo]

Any update on this? I need it to package shaderc to Fedora, which mandates the libraries to be versioned.

[dneto0]

Any update on this? I need it to package shaderc to Fedora, which mandates the libraries to be versioned.

@eclipseo : Thanks for submitting a patch. PRs are noticed more quickly than issues.

Come on people, you just have to decide on an API version and increment it every time you break API. Oh right, you’d have to care about users other than Google. Shucks.

@lachs0r:

Sorry for the delay. We do care about the whole ecosystem. For example, Shaderc is included in the SDK distributed by LunarG, and we work closely with them to ensure high quality releases. You are right, however, that most of our work is for source-based releases rather than binary inclusion in distributions such as Fedora. We can do better.

Also, we strive to not break the API. I can't remember of an instance where Shaderc broke compatibility with a previous version of the source.

[eclipseo]

Thanks for accepting the PR. I've just got the green light to package shaderc into Fedora, and then mpv and libplacebo will be rebuilt to work with it.