Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Singleton pattern around access to glslang #1059

Merged
merged 2 commits into from
May 6, 2020
Merged

Remove Singleton pattern around access to glslang #1059

merged 2 commits into from
May 6, 2020

Conversation

zoddicus
Copy link
Collaborator

@zoddicus zoddicus commented May 5, 2020

Fixes #945

@zoddicus zoddicus added the bugfix label May 5, 2020
@zoddicus zoddicus requested review from dj2 and dneto0 May 5, 2020 15:56
@zoddicus zoddicus self-assigned this May 5, 2020
dj2
dj2 reviewed May 5, 2020
View reviewed changes
dj2
dj2 approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@dj2 dj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ question

dneto0
dneto0 approved these changes May 6, 2020
View reviewed changes
@zoddicus zoddicus merged commit 26fdfbd into google:master May 6, 2020
@zoddicus zoddicus deleted the fixShadercMemoryLeaks branch May 6, 2020 18:07
@zoddicus zoddicus mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dj2 dj2 dj2 approved these changes

@dneto0 dneto0 dneto0 approved these changes

Assignees

@zoddicus zoddicus

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GlslangInitializer mutex lock?
3 participants
@zoddicus @dj2 @dneto0