tests: update tests' glslangvalidator version #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glslang bumped its major from 10 to 11. Fixing tests. Signed-off-by: Nathan Gauër <brioche@google.com>
This test counts the number of new lines in the produces binary. It iterates over the bytes, and searchs the for '\n' char. '\n' is 0xA in ASCII, but ASCII is used for other things, like a number (here GLSL version number). Updating the newline count. Signed-off-by: Nathan Gauër <brioche@google.com>
alan-baker
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRV-Tools CI started to fail because glslang version bumped (KhronosGroup/SPIRV-Tools#4970)
Signed-off-by: Nathan Gauër brioche@google.com