Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package and upload builds. #595

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Package and upload builds. #595

merged 4 commits into from
Apr 17, 2019

Conversation

fjhenigman
Copy link
Contributor

Add a step at the end of each build to install then package the
installation directory.
Name the package in the config of each build we want to upload.
Add a page that points to all the latest builds which can be downloaded.

@fjhenigman
Package and upload builds.
7c27f76 
Add a step at the end of each build to install then package the
installation directory.
Name the package in the config of each build we want to upload.
Add a page that points to all the latest builds which can be downloaded.
@fjhenigman
Fix README formatting.
c9e4bae
@fjhenigman
Fix typo in Windows download link.
80f66a0
@fjhenigman
Copy link
Contributor Author

Ready for review. You can see what the README will look like here:
https://github.com/fjhenigman/shaderc/tree/badge
I kept the three badges and linked them to what I thought would be the popular choices.
I added a separate downloads page (link just below the badges) that lists all available downloads.
The links are mostly broken until the continuous builders run but you can try the first badge on the README page.

@fjhenigman fjhenigman changed the title WIP Package and upload builds. Package and upload builds. Apr 15, 2019
ehsannas
ehsannas reviewed Apr 15, 2019
View reviewed changes
kokoro/windows/build.bat
@@ -92,8 +92,15 @@ if %VS_VERSION% NEQ 2013 (
)
echo "Tests passed %DATE% %TIME%"

:: ################################################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ninja install here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@fjhenigman
Copy link
Contributor Author

Note this will save every build, but only the latest of each kind are easily downloadable.
I made our google cloud storage publicly readable so anyone with an account can browse there to find older builds.
If we want to make older builds more easily accessible i.e. on a public web page, there's more work to do.
If we don't care about older builds, maybe we don't want to save them. They're probably a drop in the bucket, but I haven't actually tried to estimate that.

dneto0
dneto0 requested changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the need to add "ninja install" for the Windows build.

@fjhenigman fjhenigman merged commit 60caf55 into google:master Apr 17, 2019
dneto0 added a commit to dneto0/shaderc that referenced this pull request Nov 14, 2019
@dneto0
Merge remote-tracking branch 'aosp/upstream-master' into update-shaderc
afff7dc 
Includes
7425820 Start v2019.1-dev
34c412f Finish v2019.0
7e46a09 Update CHANGES
63ab5ac Re-write environment control flags to be consistent (google#637)
538a9d2 Add ability to transform spvc input from WebGPU SPIR-V (google#631)
0b84e66 Ran 2to3 on git-sync-deps (google#636)
27bffdf Roll spirv-tools dependency (google#634)
c7b4974 Remove dead file (google#632)
5ba891a Convert spirv-cross tests to using a known failures list (google#626)
05c766a Add flag to allow filtering tests cases being run (google#625)
9f04be0 Run pyformat on utils and test scripts (google#624)
326165c Run spirv-cross tests in parallel (google#622)
08549a9 Convert to requiring Python 3 (google#621)
1475418 Change 'target' env to 'source' env in spvc API (google#610)
dce7a4b Roll glslang, spirv-tools, spirv-headers, spirv-cross (google#614)
5cf297d Spvc tests: Assemble explicitly for Vulkan1.1 env (google#615)
1defed7 Fix spvc test logging (google#616)
3ac606a Update CHANGES, switch to 2019.0-dev (google#613)
55b9f5d 1.4: GOOGLE suffix drops from certain instructions
f51af41 Fix typos in the artifacts links. (google#606)
afc69d3 Disable running re2 tests (google#603)
6805e55 Fix Windows build uploads. (google#597)
60caf55 Package and upload builds. (google#595)
59a49bc Shaderc requires Python3 (google#594)
5af3dbf Roll spirv-cross. (google#592)
ff9ae40 Satisfy gn check. (google#591)
60658b0 Fix gn build. (google#590)
439a848 Export config files for pkg-config. (google#581)
2caa40b spvc: Add MSL and HLSL tests. (google#585)
1d9383f Roll DEPS. (google#586)
7bb8a43 spvc testing: add logging. (google#583)
067a749 spvc: Add some flags. (google#579)
f7fa8ce Enable spvc test. (google#578)
4b8446f Upate python scripts work with python3. (google#569)
eb0e335 Add presubmit_clang_asan bot. (google#575)
665bbc1 Add spvc command line tool and tests. (google#571)
337d42d Remove extra .clang-format files. (google#573)
cfb65d4 Fix spvc_c_smoke_test some more. (google#574)
712cebf Fix spvc_c_smoke_test. (google#572)
6bba7fe Avoid leading dot slash in cmake target. (google#570)
94f21e8 Roll GLSLang. (google#564)

Testing: checkbuild.py on Linux; unit tests on Windows
Change-Id: Ie1b63aacac7194fe8330068e6a01c5bdf44cd321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas left review comments

@dneto0 dneto0 dneto0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fjhenigman @ehsannas @dneto0