Skip to content

Commit

Permalink
Merge pull request #6721 from google/enhance/6693-engagement-rate
Browse files Browse the repository at this point in the history
Change `Engaged Sessions` to `Engagement Rate`.
  • Loading branch information
techanvil authored Mar 14, 2023
2 parents 6466d9a + 6f5ac2d commit 16ec7ba
Show file tree
Hide file tree
Showing 29 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function extractAnalytics4DashboardData(
dataLabels = [
__( 'Users', 'google-site-kit' ),
__( 'Sessions', 'google-site-kit' ),
__( 'Engaged Sessions', 'google-site-kit' ),
__( 'Engagement Rate', 'google-site-kit' ),
__( 'Session Duration', 'google-site-kit' ),
],
dataFormats = [
Expand Down
4 changes: 2 additions & 2 deletions assets/js/modules/analytics-4/utils/overall-page-metrics.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ export function calculateOverallPageMetricsData( report, startDate ) {
},
{
metric: 'engagementRate',
title: __( 'Engaged Sessions', 'google-site-kit' ),
title: __( 'Engagement Rate', 'google-site-kit' ),
sparkLineData: [
[
{ type: 'date', label: 'Day' },
{ type: 'number', label: 'Engaged Sessions' },
{ type: 'number', label: 'Engagement Rate' },
],
],
datapointUnit: '%',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ function ModulePopularPagesWidgetGA4( props ) {
),
},
{
title: __( 'Engaged Sessions', 'google-site-kit' ),
description: __( 'Engaged Sessions', 'google-site-kit' ),
title: __( 'Engagement Rate', 'google-site-kit' ),
description: __( 'Engagement Rate', 'google-site-kit' ),
hideOnMobile: true,
field: 'metricValues.2.value',
Component: ( { fieldValue } ) => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ const Overview = ( {
...( showGA4 && dashboardType === DASHBOARD_TYPE_ENTITY
? [
{
id: 'engaged-sessions',
id: 'engagement-rate',
stat: 4,
title: __( 'Engaged Sessions', 'google-site-kit' ),
title: __( 'Engagement Rate', 'google-site-kit' ),
datapoint: ga4EngagedSessionsDatapoint,
change: ga4EngagedSessionsChange,
isGatheringData: isGA4GatheringData,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ const SearchFunnelWidgetGA4 = ( { Widget, WidgetReportError } ) => {
metrics={ SearchFunnelWidgetGA4.metrics }
dataLabels={ [
__( 'Conversions', 'google-site-kit' ),
__( 'Engaged Sessions', 'google-site-kit' ),
__( 'Engagement Rate', 'google-site-kit' ),
] }
dataFormats={ [
( x ) => parseFloat( x ).toLocaleString(),
Expand Down Expand Up @@ -508,9 +508,9 @@ SearchFunnelWidgetGA4.metrics = [
service: 'analytics-4',
},
{
id: 'engaged-sessions',
id: 'engagement-rate',
color: '#6e48ab',
label: __( 'Engaged Sessions', 'google-site-kit' ),
label: __( 'Engagement Rate', 'google-site-kit' ),
service: 'analytics-4',
},
];
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 16ec7ba

Please sign in to comment.