Merge pull request #5398 from google/bug/5351-hide-goals-cta

Bug/5351 - Show goals CTA only if the user is authenticated
google · Jun 22, 2022 · d373e71 · d373e71
2 parents d540304 + 472972e
commit d373e71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview.js b/assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview.js
@@ -118,6 +118,9 @@ const Overview = ( {
 	const isSearchConsoleGatheringData = useInViewSelect( ( select ) =>
 		select( MODULES_SEARCH_CONSOLE ).isGatheringData()
 	);
+	const isAuthenticated = useSelect( ( select ) =>
+		select( CORE_USER ).isAuthenticated()
+	);
 
 	const {
 		totalClicks,
@@ -172,6 +175,7 @@ const Overview = ( {
 			! error );
 
 	const showGoalsCTA =
+		isAuthenticated &&
 		showAnalytics &&
 		dashboardType === DASHBOARD_TYPE_MAIN &&
 		! analyticsGoalsData?.items?.length;

diff --git a/assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/index.stories.js b/assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/index.stories.js
@@ -24,6 +24,7 @@ import {
 	provideModuleRegistrations,
 	provideModules,
 	provideSiteInfo,
+	provideUserAuthentication,
 	provideUserCapabilities,
 	WithTestRegistry,
 } from '../../../../../../../tests/js/utils';
@@ -258,6 +259,7 @@ export const ReadyWithCreateGoalCTA = Template.bind( {} );
 ReadyWithCreateGoalCTA.storyName = 'Ready with Create Goal CTA';
 ReadyWithCreateGoalCTA.args = {
 	setupRegistry: ( registry ) => {
+		provideUserAuthentication( registry );
 		provideSearchConsoleMockReport( registry, searchConsoleArgs );
 		for ( const options of analyticsArgs ) {
 			provideAnalyticsMockReport( registry, options );