Optimize settings form displays "use snippet instructions" for a moment and hides it

[eugene-manuilov]

Bug Description

When I open Optimize settings form, I see the form shows me use snippet instructions for a moment and then hides it.

Screencast.2021-07-15.20.22.15.mp4

Looks like it happens because Analytics settings haven't been resolved yet and the settings form from the Optimize module thinks that the useSnippet setting is disabled.

Steps to reproduce

1. Set up Optimize
2. Go to Settings
3. Wait a few seconds, then click Edit on Optimize
4. See the AMP experiment JSON setting input momentarily before disappearing (this can be exaggerated by simulating Slow 3G network speed)

Screenshots

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Optimize AMP experiment JSON setting input field should not display if the useSnippet setting for Analytics is disabled, or the AMP mode is false (this is the current logic)
  • This should be more strictly checked to avoid false positives when settings are not resolved yet

Implementation Brief

• Update the following conditions to use analyticsUseSnippet === false instead of ! analyticsUseSnippet:

  • site-kit-wp/assets/js/modules/optimize/components/common/UseSnippetInstructions.js

    Line 98 in f54254f

    if ( ! analyticsUseSnippet && gtmActive && gtmUseSnippet ) {

  • site-kit-wp/assets/js/modules/optimize/components/common/UseSnippetInstructions.js

    Line 127 in f54254f

    if ( ! analyticsUseSnippet ) {

Test Coverage

• N/A

Visual Regression Changes

• N/A

QA Brief

• use snippet instructions in the optimize settings form shoul no longer flash for a few ms.

Changelog entry

• Update Optimize module settings to avoid the flash of use snippet instructions when Analytics settings are being resolved.

[aaemnnosttv]

@eugene-manuilov it looks like this is no longer an issue. Can you confirm? If so, please close this issue 👍

[eugene-manuilov]

@aaemnnosttv I still see it on my end.

[tofumatt]

IB ✅

[wpdarren]

QA Update: ✅

I was able to recreate the initial issue. Then when on develop branch and reconnected Optimize, and edited the settings the issue is fixed. Use snippet instructions in the optimize settings no longer flash for a few ms.