Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Optimize settings form displays "use snippet instructions" flash. #4093

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

kuasha420
Copy link
Contributor

@kuasha420 kuasha420 commented Sep 21, 2021

Summary

Addresses issue #3720

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@github-actions
Copy link

github-actions bot commented Sep 21, 2021

Size Change: +3 B (0%)

Total Size: 1.14 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.3 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/admin.css 38.5 kB
./dist/assets/css/adminbar.css 8 kB
./dist/assets/css/wpdashboard.css 4.58 kB
./dist/assets/js/33.********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-activation.********************.js 37.9 kB
./dist/assets/js/googlesitekit-adminbar.********************.js 30.8 kB
./dist/assets/js/googlesitekit-api.********************.js 9.04 kB
./dist/assets/js/googlesitekit-base.********************.js 1.58 kB
./dist/assets/js/googlesitekit-dashboard-details.********************.js 44.4 kB
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 52.1 kB
./dist/assets/js/googlesitekit-dashboard.********************.js 44.6 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.73 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.2 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.71 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 20.9 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 23.6 kB
./dist/assets/js/googlesitekit-module.********************.js 44.4 kB
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.9 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 18.8 kB
./dist/assets/js/googlesitekit-modules-analytics.********************.js 66.3 kB
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 23.8 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.3 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.4 kB
./dist/assets/js/googlesitekit-modules-subscribe-with-google.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 29.8 kB
./dist/assets/js/googlesitekit-modules.********************.js 16.4 kB
./dist/assets/js/googlesitekit-polyfills.********************.js 377 B
./dist/assets/js/googlesitekit-settings.********************.js 48.9 kB
./dist/assets/js/googlesitekit-user-input.********************.js 45.1 kB
./dist/assets/js/googlesitekit-vendor.********************.js 312 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.4 kB
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 32.9 kB
./dist/assets/js/runtime.********************.js 1.19 kB

compressed-size-action

@kuasha420 kuasha420 requested a review from tofumatt September 21, 2021 10:27
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugene-manuilov eugene-manuilov merged commit ae0b02b into develop Sep 22, 2021
@eugene-manuilov eugene-manuilov deleted the bug/3720-optimize-settings-form-flashing branch September 22, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants