-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Idea Hub WP dashboard CTA with latest design and language #3911
Comments
IB ✅ |
@aaemnnosttv Can I ask for some clarity on this:
There does appear to be a story for this notice: https://google.github.io/site-kit-wp/storybook/develop/?path=/story/views-wpdashboardapp--ready However, I am not sure what is meant by 'this case', as the component only seems to handle one case... if the module isn't active, or there are no saved ideas it returns Thanks! |
@johnPhillips I was referring to adding a story that showed the CTA in the context of the widget but looks like the only stories we have for that are not using CSF so we wouldn't be able to compose them easily. No need to add any extras for this for the moment. We probably need an issue to migrate those stories to CSF first. |
QA Update: ❌@johnPhillips this feels a little too picky 😃 but when you get screen sizes around 359 pixels, the wrap doesn't leave much space between the notice and CTA, is there anything we can do about this? When you start to reduce the screen size below this resolution, it does wrap, for smaller screens. |
Thanks @wpdarren – I'm not sure this is really a QA failure but we can definitely tweak this to make it a little cleaner and consistent 👍 @johnPhillips would you please add the same margin to the right of the copy that we have on the logo so that we have equal minimum space between the copy on both sides? I suppose we could just move the margin to be only on the copy but that's a bit of an implementation detail 😄 |
@wpdarren the spacing issue has been fixed. Additionally the link text has been changed to "View Ideas" to take a little less room as well. Ready for another pass! |
QA Update ✅Verified:
|
Feature Description
The Idea Hub CTA in the Site Kit WP dashboard widget should be updated with the latest design and wording related to #3852
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
The following all apply to the Idea Hub WP dashboard component (
WPDashboardIdeaHub
)Overall the CTA should look like this:
Update: the link text is now
View Ideas
(see #3992 (comment))Implementation Brief
Test Coverage
Visual Regression Changes
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: