Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Idea Hub WP dashboard CTA with latest design and language (3911). #3977

Merged
merged 7 commits into from
Sep 3, 2021

Conversation

johnPhillips
Copy link
Contributor

@johnPhillips johnPhillips commented Sep 1, 2021

Summary

Addresses issue #3911

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla
Copy link

google-cla bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 1, 2021
@johnPhillips
Copy link
Contributor Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@johnPhillips
Copy link
Contributor Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Sep 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size Change: -9 B (0%)

Total Size: 1.13 MB

Filename Size Change
./dist/assets/css/wpdashboard.css 4.58 kB +1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 32.5 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/admin.css 38.5 kB
./dist/assets/css/adminbar.css 8 kB
./dist/assets/js/33.********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-activation.********************.js 37.7 kB
./dist/assets/js/googlesitekit-adminbar.********************.js 30.6 kB
./dist/assets/js/googlesitekit-api.********************.js 9.04 kB
./dist/assets/js/googlesitekit-base.********************.js 1.59 kB
./dist/assets/js/googlesitekit-dashboard-details.********************.js 44.1 kB
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 51.8 kB
./dist/assets/js/googlesitekit-dashboard.********************.js 44.1 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.73 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.2 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.71 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 20.9 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 23.8 kB
./dist/assets/js/googlesitekit-module.********************.js 44 kB
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.6 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 18.8 kB
./dist/assets/js/googlesitekit-modules-analytics.********************.js 65.6 kB
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 23.2 kB
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.3 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.3 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.4 kB
./dist/assets/js/googlesitekit-modules-subscribe-with-google.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 29.9 kB
./dist/assets/js/googlesitekit-modules.********************.js 16.4 kB
./dist/assets/js/googlesitekit-polyfills.********************.js 376 B
./dist/assets/js/googlesitekit-settings.********************.js 48.6 kB
./dist/assets/js/googlesitekit-user-input.********************.js 44.8 kB
./dist/assets/js/googlesitekit-vendor.********************.js 312 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.4 kB
./dist/assets/js/runtime.********************.js 1.19 kB

compressed-size-action

@aaemnnosttv
Copy link
Collaborator

@googlebot I consent.

@google-cla

This comment has been minimized.

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aaemnnosttv aaemnnosttv merged commit 55793ed into develop Sep 3, 2021
@aaemnnosttv aaemnnosttv deleted the enhance/3911-wp-dashboard-cta branch September 3, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants