-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Widget: Overall Page Metrics #4122
Comments
@tofumatt The ACs here are somehow a duplicate off #4123 - that one is actually about the search funnel. Sticking to the (correct) issue description here, this issue is not about the search funnel, it is about "overall page metrics", which are all Analytics metrics. The only thing this has to do with the search funnel is that it should visually look like today's search funnel widget, but semantically it is unrelated. Can you rewrite the ACs here to focus on the "overall page metrics" widget? Also the title should probably be changed as it has nothing really to do with a search funnel. The widget JS file here can live in the Analytics module, since it only pulls stats from Analytics. Last but not least: Let's add one more bullet point to the ACs that this widget should also be registered on the entity dashboard, which is technically a follow-up to #4078, since the widget at that point doesn't exist yet. |
@felixarntz Sounds good—as mentioned I think the mix-up between the Design Doc/PRD and the Figma designs sometimes meant I got these shuffled around in my head—though here I thought I updated this, and maybe I just didn't hit "submit" on my changes or something 😓 At any rate, I've updated the ACs to include the right info for this widget, and include registering it once created. If these ACs look good feel free to move it over to IB 👍🏻 |
@tofumatt No worries, looks good now! Only a few comments where I think it could be clarified:
Is that a placeholder? Maybe we should specify something like
That's not something we've defined before on how it should be, but I think we should rephrase this to not show the entire widget at all if Analytics is not active/connected, for two reasons:
Let me know if that sounds good to you, and if so could you update the ACs? Other than that lgtm! |
Ah, shoot, that was indeed a placeholder or a typo! Fixed the file issue. Regarding not showing the widget at all: that seems fine to me. I thought the CTA might be useful but true: it's not in the original doc and your reasoning here makes sense. I've amended the ACs so I think this is good; moving to IB 👍🏻 |
@felixarntz @tofumatt AC says that this widget should display the Bounce Rate metric. Do we need to display it on the main dashboard as well or only on the entity dashboard page? I am asking because currently, we display it only on the entity page and don't on the dashboard page. |
@eugene-manuilov Yes, the Bounce Rate should be included here regardless. The only reason it's only displayed on the entity dashboard today is because as part of the Search Funnel, it's only a "fallback" to goals, which are not really applicable at the per-page level. That's not really important for the widget here though, as bounce rate is also a relevant metric at the site level. |
IB ✅ |
@eugene-manuilov @tofumatt the IB suggests creating Should I update the IB to create the widget in Also - is this degree of deviation from the IB enough to merit the question? :) |
@eugene-manuilov @tofumatt also, I have a feeling that |
@felixarntz @tofumatt @eugene-manuilov Another question - should the new Overall Page Metrics widget include title/subtitle text, similar to the Search Console design, and if so, what should the copy be? Thanks! Update: Looking into this a bit further, would this be the right approach - following the same title style as the "Top content" widget? |
@felixarntz @tofumatt @eugene-manuilov hi, folks - can someone also please clarfify what the report type/URL(s) & any necessary args should be for the links? I've currently got it pencilled in as a |
@techanvil Great questions, I guess this was a bit too loosely specified:
Let's not add an overall heading for the new widget, each column having its own "heading" (Pageviews, Unique Pageviews, etc.) is sufficient.
We can keep using the current Also, good catch putting "Bounce Rate" before "Session Duration" (based on your screenshot)! This differs from the order in the ACs, but it makes sense to align this with the order in #4124 (comment). |
Hi @cole10up, you might have already spotted this, but I have noticed that I have missed out the unit character(s) for Bounce Rate and Session Duration when implementing the Overall Page Metrics widget, as is apparent when comparing it to a similar widget. |
QA ❌Thanks for logging the character fix @techanvil I was able to confirm statistics on the new widget: Verified the Analytics link. I noticed with the unified dashboard feature flag on - the analytics and search console pages are showing blank: Flipping the feature flag off shows these pages with proper content. Sending back to @techanvil to check. |
I will give this a run through as a sanity check and then approve. 😄 |
QA Update: ✅I've sent this to approved. Cole previously confirmed that the only issue was blank module pages. @felixarntz @tofumatt one small observation: I did notice in the AC, widgets were ordered: Session Duration |
@wpdarren You're right - I've now updated this in the ACs as well, for any future reference. |
Feature Description
Based on the existing Search Funnel Widgets (see:
dashboardSearchFunnel
Widget Area) create a new widget with 4<Sparkline />
components with the following data from Analytics:Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
assets/js/modules/analytics/components/dashboard/OverallPageMetricsWidget
.dashboardSearchFunnel
Widget Area, show four Sparkline graphs with the following Analytics metrics:return null;
or should use thewhenActive
HOC)site-kit-wp/assets/js/modules/search-console/index.js
Lines 60 to 79 in d77d4fc
site-kit-wp/assets/js/modules/analytics/index.js
Lines 84 to 104 in d77d4fc
unifiedDashboard
feature flag is enabled, specifically added to themainDashboardContent
andentityDashboardContent
widget areas as full-width widgets. It should appear as the third widget in each of these widget areas. See order in Unified Dashboard: Register existing widgets in new Content area #4078.Implementation Brief
DashboardOverallPageMetricsWidget
widget inanalytics/components/dashboard/DashboardOverallPageMetricsWidget
—it should be functionally/visually similar to thedashboardSearchFunnel
Widget Area—see the ACs. Use thewhenActive
HOC to make sure that the widget is not rendered if the Analytics module is not active or not connected.isGatheringData
status using theselect( MODULES_ANALYTICS ).isGatheringData()
selector.ga:pageviews
,ga:uniquePageviews
,ga:avgSessionDuration
, andga:bounceRate
.undefined
.isGatheringData
variable euqalstrue
or theisZeroReport
function call returnstrue
unifiedDashboard
feature flag is enabled:slug
should beanalyticsOverallPageMetrics
width
should beFULL
priority
should be3
widgetAreas
array should containAREA_MAIN_DASHBOARD_TRAFFIC_PRIMARY
andAREA_ENTITY_DASHBOARD_TRAFFIC_PRIMARY
area slugsTest Coverage
QA Brief
Note: Please read this comment which clarifies a couple of points about the AC.
For reference here's a screen grab of the new widget:
Changelog entry
The text was updated successfully, but these errors were encountered: